Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ips): order vrack ipv4 #14838

Merged
merged 1 commit into from
Jan 22, 2025
Merged

feat(ips): order vrack ipv4 #14838

merged 1 commit into from
Jan 22, 2025

Conversation

chipp972
Copy link
Contributor

@chipp972 chipp972 commented Jan 8, 2025

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-15838
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@chipp972 chipp972 requested review from a team as code owners January 8, 2025 17:04
@chipp972 chipp972 requested review from anooparveti, ghyenne, sidlynx, kqesar and tibs245 and removed request for a team January 8, 2025 17:05
@github-actions github-actions bot added translation required dependencies Pull requests that update a dependency file feature New feature labels Jan 8, 2025
@chipp972 chipp972 changed the base branch from feat/region-selector-component to feat/ips-region-selector January 8, 2025 17:05
@chipp972 chipp972 force-pushed the feat/15838-order-vrack-ipv4 branch from bd661ab to 0e40b5f Compare January 8, 2025 17:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@ovhcloud/ods-components UPDATED 18.4.1 18.5.0
flag-icons REMOVED 7.2.3 -

@chipp972 chipp972 force-pushed the feat/15838-order-vrack-ipv4 branch 3 times, most recently from 43b9d48 to 6b9203a Compare January 17, 2025 15:50
@chipp972 chipp972 changed the title Feat/15838 order vrack ipv4 feat(ips): order vrack ipv4 Jan 17, 2025
@chipp972 chipp972 force-pushed the feat/15838-order-vrack-ipv4 branch from 6b9203a to bcc7b14 Compare January 20, 2025 14:21
Base automatically changed from feat/ips-region-selector to project/ip-revamp January 20, 2025 14:23
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jan 20, 2025
@chipp972 chipp972 force-pushed the feat/15838-order-vrack-ipv4 branch from bcc7b14 to 7b3521a Compare January 20, 2025 14:27
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jan 20, 2025
@chipp972 chipp972 force-pushed the feat/15838-order-vrack-ipv4 branch from 7b3521a to f36c7f9 Compare January 20, 2025 14:31
@chipp972 chipp972 force-pushed the feat/15838-order-vrack-ipv4 branch from f36c7f9 to 6b9ccbe Compare January 22, 2025 09:55
feat(ips): order ipv4 vrack
58b6e63 
ref: MANAGER-15838

Signed-off-by: Nicolas Pierre-charles <[email protected]>
@chipp972 chipp972 force-pushed the feat/15838-order-vrack-ipv4 branch from 6b9ccbe to 58b6e63 Compare January 22, 2025 10:15
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@chipp972 chipp972 merged commit 743eae7 into project/ip-revamp Jan 22, 2025
12 of 13 checks passed
@chipp972 chipp972 deleted the feat/15838-order-vrack-ipv4 branch January 22, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhelhali-soufien mhelhali-soufien mhelhali-soufien approved these changes

@qpavy qpavy qpavy approved these changes

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chipp972 @qpavy @mhelhali-soufien