Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mrc): add changelog component #14889
base: develop
Are you sure you want to change the base?
feat(mrc): add changelog component #14889
Changes from all commits
427c37e
280ef2f
3ac2018
335bff4
76397da
7f43fda
18f544a
e340917
aa7556a
2852aa4
a6d5519
32bdc1b
7d5ff7b
95997b0
f0ee801
bae89db
05ea723
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: Instead of accepting all the buttons as one single react node, i think it can be beneficial to accept it as a separate prop called
changelogButton
. Also, since the current prop is justheaderButton
(singular button) it does not convey implicitly that it could accept and well adjust the layout for more buttons.