Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): acquisition storage #9209

Merged
merged 19 commits into from
Aug 9, 2023
Merged

feat(*): acquisition storage #9209

merged 19 commits into from
Aug 9, 2023

Conversation

anooparveti
Copy link
Contributor

@anooparveti anooparveti commented Apr 24, 2023 •
edited by sachinrameshn
Loading

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets ECAN-1674
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

  1. Addition of "My Identity Documents" section
  2. KYC - Banner to inform customers
  3. New page - Upload my Identity files
  4. Also tracking

Related

@sachinrameshn sachinrameshn marked this pull request as ready for review May 23, 2023 13:06
@sachinrameshn sachinrameshn requested a review from a team as a code owner May 23, 2023 13:06
@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed.

@github-actions github-actions bot added the stale No activity since a long time label Jul 17, 2023
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jul 24, 2023
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging and removed has conflicts Has conflicts to resolve before merging labels Jul 27, 2023
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jul 31, 2023
anooparveti and others added 5 commits August 7, 2023 12:21
@sachinrameshn
feat(dedicated): update content on kyc page (#9294)
9871885 
ref: MANAGER-11431

Signed-off-by: sachinrameshn <[email protected]>
@sachinrameshn
feat(*): disable kyc upload option for status open (#9308)
af9c43d 
ref: MANAGER-11202

Signed-off-by: sachinrameshn <[email protected]>
@sachinrameshn
feat(dedicated): add redirection for kyc page (#9319)
6528cda 
ref: MANAGER-11157

Signed-off-by: sachinrameshn <[email protected]>
@sachinrameshn
feat(dedicated): update re direction link (#9322)
408ed4e 
ref: MANAGER-11433

Signed-off-by: sachinrameshn <[email protected]>
@sachinrameshn
fix(dedicated): display info banner based on status (#9333)
ec16ad8 
ref: MANAGER-11448

Signed-off-by: sachinrameshn <[email protected]>
@sachinrameshn
feat(dedicated): implement tracking for acquisition storage (#9345)
0964e96 
ref: MANAGER-11348

Signed-off-by: sachinrameshn <[email protected]>
@sachinrameshn
fix(dedicated): update description of kyc page (#9367)
f6b501f 
ref: MANAGER-11499

Signed-off-by: sachinrameshn <[email protected]>
@sachinrameshn
fix(dedicated): acquisition add india termsofuse link (#9397)
b418b4d 
ref: MANAGER-11432

Signed-off-by: sachinrameshn <[email protected]>
@sachinrameshn
fix(dedicated): design improvements for kyc (#9420)
a9874a7 
ref: MANAGER-11558

Signed-off-by: sachinrameshn <[email protected]>
@sachinrameshn
fix(dedicated): add content based on customer type (#9422)
58ab1ef 
ref: MANAGER-11500

Signed-off-by: sachinrameshn <[email protected]>
@sachinrameshn
feat(dedicated): css suggestion and bug fix (#9423)
d54d0f7 
ref: MANAGER-11555

Signed-off-by: sachinrameshn <[email protected]>
@sachinrameshn
feat(dedicated): add documents list (#9440)
754e21e 
ref: MANAGER-11580

Signed-off-by: sachinrameshn <[email protected]>
@sachinrameshn
feat(dedicated): update content (#9466)
05acc77 
ref: MANAGER-11580

Signed-off-by: sachinrameshn <[email protected]>
@sachinrameshn
fix(i18n): add missing translations [CDS 2399]
c5f3c93 
Signed-off-by: CDS Translator Agent <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sachinrameshn sachinrameshn self-requested a review August 7, 2023 10:07
@JacquesLarique JacquesLarique changed the base branch from master to release/components-projects-w32 August 9, 2023 07:05
@JacquesLarique JacquesLarique merged commit f7808f8 into release/components-projects-w32 Aug 9, 2023
12 of 14 checks passed
@JacquesLarique JacquesLarique deleted the feat/acquisition-storage branch August 9, 2023 07:21
@JacquesLarique JacquesLarique mentioned this pull request Aug 9, 2023
Merged
3 tasks
JacquesLarique pushed a commit that referenced this pull request Aug 9, 2023
@anooparveti @sachinrameshn @ovh-cds
feat(*): acquisition storage (#9209)
1b4f088 
ref: MANAGER-11155

Signed-off-by: Anoop N <[email protected]>
Co-authored-by: sachinrameshn <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
JacquesLarique pushed a commit that referenced this pull request Aug 10, 2023
@anooparveti @sachinrameshn
@ovh-cds @JacquesLarique
feat(*): acquisition storage (#9209)
e709587 
ref: MANAGER-11155

Signed-off-by: Anoop N <[email protected]>
Co-authored-by: sachinrameshn <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
BrunoMarquesOVH pushed a commit that referenced this pull request Aug 31, 2023
@anooparveti @sachinrameshn
@ovh-cds @BrunoMarquesOVH
feat(*): acquisition storage (#9209)
96b354f 
ref: MANAGER-11155

Signed-off-by: Anoop N <[email protected]>
Co-authored-by: sachinrameshn <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@qpavy qpavy qpavy approved these changes

@y4nnL y4nnL Awaiting requested review from y4nnL y4nnL was automatically assigned from ovh/team-manager-dev-angularjs

@stif59100 stif59100 Awaiting requested review from stif59100 stif59100 was automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn

Assignees
No one assigned
Labels
container feature New feature quality check: ok universe-bare-metal-cloud universe-hub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anooparveti @qpavy @darsene @sachinrameshn @JacquesLarique