Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sign-up): sms marketing consent #9679

Merged
merged 7 commits into from
Aug 3, 2023
Merged

feat(sign-up): sms marketing consent #9679

merged 7 commits into from
Aug 3, 2023

Conversation

JacquesLarique
Copy link
Contributor

@JacquesLarique JacquesLarique commented Jul 19, 2023 •
edited
Loading

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-11426
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Adding phone type and consent for sms marketing in the sign up page

Related

Translation ticket:

  • TRANS-52571

@JacquesLarique JacquesLarique requested a review from a team as a code owner July 19, 2023 10:14
qpavy
qpavy previously approved these changes Jul 19, 2023
View reviewed changes
darsene
darsene previously approved these changes Jul 19, 2023
View reviewed changes
@JacquesLarique JacquesLarique dismissed stale reviews from darsene and qpavy via 4c905b1 July 20, 2023 07:16
anooparveti
anooparveti previously approved these changes Jul 26, 2023
View reviewed changes
@JacquesLarique JacquesLarique changed the base branch from master to feat/sms-consent-management August 1, 2023 10:20
anooparveti
anooparveti requested changes Aug 2, 2023
View reviewed changes
packages/manager/apps/sign-up/src/routing.js Outdated
$window.location.assign(redirectUrl);
}
const promise =
region !== 'US' ? signUp.sendSmsConsent(smsConsent) : $q.resolve();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Use feature-flipping instead of checking for region.

@github-actions github-actions bot added translation required has conflicts Has conflicts to resolve before merging labels Aug 2, 2023
@JacquesLarique JacquesLarique removed translation required has conflicts Has conflicts to resolve before merging labels Aug 2, 2023
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Aug 2, 2023
Jacques Larique added 4 commits August 3, 2023 10:08
feat(sign-up): update sign up page display
a4a1b08 
ref: MANAGER-11426

Signed-off-by: Jacques Larique <[email protected]>
feat(sign-ip): adding phone type to sign up
2986c04 
ref: MANAGER-11426

Signed-off-by: Jacques Larique <[email protected]>
feat(sign-up): adding sms consent
11aa4e6 
ref: MANAGER-11426

Signed-off-by: Jacques Larique <[email protected]>
feat(sign-up): miscellaneous fixes
0d9e720 
ref: MANAGER-11426

Signed-off-by: Jacques Larique <[email protected]>
CDS Translator Agent added 3 commits August 3, 2023 10:08
fix(i18n): add missing translations [CDS 2403]
b2cc8cd 
Signed-off-by: CDS Translator Agent <[email protected]>
feat(sign-up): consent request management
eb0f63d 
ref: MANAGER-11426

Signed-off-by: Jacques Larique <[email protected]>
feat(sign-up): restrict request for us
31b6008 
ref: MANAGER-11426

Signed-off-by: Jacques Larique <[email protected]>
@github-actions github-actions bot added translation required and removed has conflicts Has conflicts to resolve before merging labels Aug 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JacquesLarique JacquesLarique merged commit 23d44a8 into feat/sms-consent-management Aug 3, 2023
11 of 12 checks passed
@JacquesLarique JacquesLarique deleted the feat/MANAGER-11426 branch August 3, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anooparveti anooparveti anooparveti requested changes

@darsene darsene darsene approved these changes

@qpavy qpavy qpavy approved these changes

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature sign-up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JacquesLarique @qpavy @anooparveti @darsene