Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/manager-11620-BIS - Tile Billing supercomponent add mock #9721

Merged
merged 2 commits into from
Jul 26, 2023
Merged

feat/manager-11620-BIS - Tile Billing supercomponent add mock #9721

merged 2 commits into from
Jul 26, 2023

Conversation

aboungnaseng-ovhcloud
Copy link
Contributor

Question Answer
Branch? master / release/** / develop
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets Fix #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud requested a review from a team as a code owner July 26, 2023 13:38
@aboungnaseng-ovhcloud aboungnaseng-ovhcloud requested review from y4nnL, anooparveti and JacquesLarique and removed request for a team July 26, 2023 13:38
@github-actions github-actions bot added dependencies Pull requests that update a dependency file feature New feature labels Jul 26, 2023
@aboungnaseng-ovhcloud aboungnaseng-ovhcloud changed the title Feat/manager 11620 bis feat/manager-11620-BIS - Tile Billing supercomponent add mock Jul 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
31.1% 31.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Kranysys Kranysys self-requested a review July 26, 2023 14:02
@Kranysys Kranysys merged commit ed1ee1b into feat/MANAGER-11620 Jul 26, 2023
12 of 13 checks passed
@Kranysys Kranysys deleted the feat/MANAGER-11620-bis branch July 26, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kranysys Kranysys Kranysys approved these changes

@y4nnL y4nnL Awaiting requested review from y4nnL y4nnL was automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti was automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aboungnaseng-ovhcloud @Kranysys