New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dedicated): fix reloading page on locale language change #9727

Merged

darsene merged 1 commit into release/carbon-calculator from fix/carbon-calculator

Jul 27, 2023

Contributor

darsene commented Jul 26, 2023

ref: MANAGER-11240

Question	Answer
Branch?	`release/carbon-calculator`
Bug fix?	yes
New feature?	no
Breaking change?	no
Tickets	Fix #MANAGER-11240
License	BSD 3-Clause

Try to keep pull requests small so they can be easily reviewed.
Commits are signed-off
~~Only FR translations have been updated~~
Branch is up-to-date with target branch
Lint has passed locally
Standalone app was ran and tested locally
Ticket reference is mentioned in linked commits (internal only)
~~Breaking change is mentioned in relevant commits~~

Description

Fix page reloading when you change manager language

Related


          fix(dedicated): fix reloading page on locale language change

8bd2dbe

ref: MANAGER-11240

Signed-off-by: David Arsène <[email protected]>

darsene requested a review from a team as a code owner

July 26, 2023 17:32

darsene requested review from y4nnL, anooparveti and JacquesLarique and removed request for a team

July 26, 2023 17:32

github-actions bot added the bug label

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

sachinrameshn approved these changes

View reviewed changes

qpavy approved these changes

View reviewed changes

anooparveti approved these changes

View reviewed changes

darsene merged commit 24b6044 into release/carbon-calculator

13 checks passed

darsene deleted the fix/carbon-calculator branch

July 27, 2023 07:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sachinrameshn sachinrameshn approved these changes

anooparveti anooparveti approved these changes

qpavy qpavy approved these changes

y4nnL Awaiting requested review from y4nnL y4nnL was automatically assigned from ovh/team-manager-dev-angularjs

JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique was automatically assigned from ovh/team-manager-dev-angularjs

Labels

bug