Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web.hosting): fix the order of web cloud database #9734

Merged
merged 1 commit into from
Jul 27, 2023
Merged

fix(web.hosting): fix the order of web cloud database #9734

merged 1 commit into from
Jul 27, 2023

Conversation

ghyenne
Copy link
Contributor

@ghyenne ghyenne commented Jul 27, 2023

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets MANAGER-11651
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

I fixed the order of web cloud database

Related

@ghyenne ghyenne requested a review from a team as a code owner July 27, 2023 13:30
@github-actions github-actions bot added universe-web-cloud bug Something isn't working labels Jul 27, 2023
anooparveti
anooparveti reviewed Jul 27, 2023
View reviewed changes
...pps/web/client/app/hosting/database/order/public/hosting-database-order-public.controller.js Outdated
Comment on lines 64 to 66
] = this.model.dbCategory.selectVersion.configurations.find(
(item) => item.name === DATACENTER_CONFIGURATION_KEY,
).values;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
] = this.model.dbCategory.selectVersion.configurations.find(
(item) => item.name === DATACENTER_CONFIGURATION_KEY,
).values;
] = this.model.dbCategory.selectVersion.configurations.find(
(item) => item.name === DATACENTER_CONFIGURATION_KEY,
)?.values;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fixed

darsene
darsene requested changes Jul 27, 2023
View reviewed changes
...pps/web/client/app/hosting/database/order/public/hosting-database-order-public.controller.js Show resolved Hide resolved
...pps/web/client/app/hosting/database/order/public/hosting-database-order-public.controller.js Show resolved Hide resolved
...pps/web/client/app/hosting/database/order/public/hosting-database-order-public.controller.js
: '';
}

getOnGetConfiguration() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getOnGet ? the function name is not very clear

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just add get begining the name of object required by product offer module

packages/manager/modules/product-offers/src/workflows/product-offers-order-workflow.class.js Show resolved Hide resolved
packages/manager/modules/product-offers/src/workflows/product-offers-order-workflow.class.js Show resolved Hide resolved
packages/manager/modules/product-offers/src/workflows/product-offers-order-workflow.class.js Show resolved Hide resolved
anooparveti
anooparveti reviewed Jul 27, 2023
View reviewed changes
packages/manager/modules/product-offers/src/workflows/product-offers-order-workflow.class.js
Comment on lines +179 to +181
isFunction(this.productName)
? this.productName()
: this.productName,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: This is pretty confusing. Can we just maintain this.productName to be always string.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact i need to have something to dynamic. Because in my order funnel database the all type of database haven't same product name and one need service name because is an option other no because is individual service.

@ghyenne
fix(web.hosting): fix the order of web cloud database
4540328 
ref: MANAGER-11651

Signed-off-by: Guillaume Hyenne <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ghyenne ghyenne changed the base branch from master to release/hotfix-nwo July 27, 2023 14:58
@ghyenne ghyenne merged commit 17c4b0e into release/hotfix-nwo Jul 27, 2023
12 checks passed
@ghyenne ghyenne deleted the fix/MANAGER-11651 branch July 27, 2023 15:03
@ghyenne ghyenne mentioned this pull request Jul 27, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darsene darsene darsene approved these changes

@anooparveti anooparveti anooparveti approved these changes

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
bug Something isn't working quality check: ok universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghyenne @anooparveti @darsene