feat(ldp): add stream subscriptions #9736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
universe-bare-metal-cloud
translation required
feature
pfrayer
force-pushed
the
feat/pierre.frayer/ldp_subscriptions_view
branch
from
ed56ffd
to
6726d3a
Compare
darsene
requested changes
Jul 28, 2023
...ages/manager/modules/dbaas-logs/src/logs/detail/streams/home/logs-streams-home.controller.js
Outdated
Show resolved
Hide resolved
...modules/dbaas-logs/src/logs/detail/streams/subscriptions/streams-subscriptions.controller.js
Outdated
Show resolved
Hide resolved
...modules/dbaas-logs/src/logs/detail/streams/subscriptions/streams-subscriptions.controller.js
Outdated
Show resolved
Hide resolved
packages/manager/modules/dbaas-logs/src/logs/detail/streams/home/logs-streams-home.html
Outdated
Show resolved
Hide resolved
...er/modules/dbaas-logs/src/logs/detail/streams/subscriptions/streams-subscriptions.service.js
Show resolved
Hide resolved
|
@pfrayer can you please the contributing guide https://github.com/ovh/manager/blob/master/CONTRIBUTING.md and sign off your commit |
anooparveti
requested changes
Jul 28, 2023
...modules/dbaas-logs/src/logs/detail/streams/subscriptions/streams-subscriptions.controller.js
Outdated
Show resolved
Hide resolved
anooparveti
reviewed
Jul 28, 2023
.../manager/modules/dbaas-logs/src/logs/detail/streams/subscriptions/subscriptions.component.js
Outdated
Show resolved
Hide resolved
anooparveti
requested changes
Jul 28, 2023
...ges/manager/modules/dbaas-logs/src/logs/detail/streams/subscriptions/subscriptions.module.js
Outdated
Show resolved
Hide resolved
pfrayer
force-pushed
the
feat/pierre.frayer/ldp_subscriptions_view
branch
from
6726d3a
to
ae04961
Compare
|
SonarCloud Quality Gate failed.
|
darsene
previously approved these changes
Jul 28, 2023
anooparveti
previously approved these changes
Aug 2, 2023
|
This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed. |
antleblanc
dismissed stale reviews from anooparveti and darsene
via
310dd40
github-actions
bot
added
the
has conflicts
pfrayer
force-pushed
the
feat/pierre.frayer/ldp_subscriptions_view
branch
from
310dd40
to
4c0bf96
Compare
github-actions
bot
removed
the
has conflicts
|
Translations pulled & rebased on |
darsene
approved these changes
Sep 26, 2023
anooparveti
approved these changes
Sep 26, 2023
ref: OB-5034 Signed-off-by: Pierre Frayer <[email protected]>
Signed-off-by: CDS Translator Agent <[email protected]>
pfrayer
force-pushed
the
feat/pierre.frayer/ldp_subscriptions_view
branch
from
4c0bf96
to
13a8df8
Compare
|
SonarCloud Quality Gate failed.
|
15 tasks
ghyenne
pushed a commit
that referenced
this pull request
Oct 5, 2023
ref: OB-5034 Signed-off-by: Pierre Frayer <[email protected]> Signed-off-by: CDS Translator Agent <[email protected]>
brofik
pushed a commit
that referenced
this pull request
Oct 11, 2023
ref: OB-5034 Signed-off-by: Pierre Frayer <[email protected]> Signed-off-by: CDS Translator Agent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developDescription
Hello 👋
We (Logs Data Platform) are working on a new feature where we'll enable logs observability inside OVHcloud products.
The aim for managed products (Web Hosting, Managed Kubernetes Service, CDN etc.) is to allow customer to forward the logs of their managed products inside their own Logs Data Platform stream. Like this customer will be able to orchestrate their OVHcloud products logs, search in their products logs, create dashboard from it etc.
To do so, in each Manager product section (Web Hosting, Managed Kubernetes Service, CDN etc.) customer will have a kind of "Forwards logs to my own LDP stream" button. Once activated, this is create a "logs subscription".
Once done, customer should be able to see all their subscriptions, and should be able to delete them (aka unsubscribe).
This PR bring this last part: list & delete subscriptions in the Logs Data Platform section of the Manager.
Full details about this feature is available in the linked internal ticket