feat(project.new): Add the legal text and a checkbox in the second step of a project creation #9847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
translation required
universe-public-cloud
feature
qpavy
previously approved these changes
Aug 18, 2023
JacquesLarique
previously approved these changes
Aug 18, 2023
anooparveti
previously approved these changes
Aug 29, 2023
JacquesLarique
previously approved these changes
Aug 29, 2023
qpavy
previously approved these changes
Aug 29, 2023
sachinrameshn
requested changes
Sep 1, 2023
| } | ||
|
|
||
| displayCreateProjectButton() { | ||
| if (this.model.paymentMethod.type.isCreditCard()) { |
There was a problem hiding this comment.
I guess we dont display this component for the card type credit card. We have another component in the same file <ovh-payment-method-integration which will display only if $ctrl.model.paymentMethod.isHandleByComponent()
8 tasks
brofik
dismissed stale reviews from qpavy, JacquesLarique, and anooparveti
via
f185d88
sachinrameshn
previously approved these changes
Sep 7, 2023
sachinrameshn
force-pushed
the
feat/TAPC-83
branch
from
9f40b88
to
87559c8
Compare
anooparveti
requested changes
Sep 14, 2023
|
|
||
| hasLegalAgreements() { | ||
| return Object.values(this.model.legalAgreements).find( | ||
| (elm) => elm === true, |
There was a problem hiding this comment.
Suggested change
| (elm) => elm === true, | |
| (agreement) => agreement === true, |
sachinrameshn
force-pushed
the
feat/TAPC-83
branch
2 times, most recently
from
1839682
to
ffdf9a8
Compare
github-actions
bot
added
the
has conflicts
added 2 commits
October 17, 2023 09:29
ref: MANAGER-11567 Signed-off-by: Rafik Adiche <[email protected]>
ref: MANAGER-11618 Signed-off-by: Rafik Adiche <[email protected]>
ref: MANAGER-11567 Signed-off-by: Rafik Adiche <[email protected]>
Signed-off-by: CDS Translator Agent <[email protected]>
ref: TAPC-83 Signed-off-by: Rafik Adiche <[email protected]>
ref: TAPC-150 Signed-off-by: Rafik Adiche <[email protected]>
ref: TAPC-150 Signed-off-by: Guillaume Hyenne <[email protected]>
ref: TAPC-150 Signed-off-by: Rafik Adiche <[email protected]>
ref: TAPC-83 Signed-off-by: Rafik Adiche <[email protected]>
github-actions
bot
removed
the
has conflicts
|
Kudos, SonarCloud Quality Gate passed!
|
|
This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed. |
|
This Pull Request is now closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterDescription
Related
TAPC-83: #9779
TAPC-150 : #9831