Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(projects.new): implement the checkbox for legal agreement #9875

Merged
merged 1 commit into from
Aug 23, 2023
Merged

feat(projects.new): implement the checkbox for legal agreement #9875

merged 1 commit into from
Aug 23, 2023

Conversation

brofik
Copy link
Contributor

@brofik brofik commented Aug 23, 2023

ref: TAPC-150

Question Answer
Branch? feat/TAPC-83
Bug fix? no
New feature? yes
Breaking change? yes
Tickets Fix #TAPC-83
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

same as #9831

@brofik brofik requested a review from a team as a code owner August 23, 2023 04:37
@brofik brofik requested review from y4nnL, darsene and BrunoMarquesOVH and removed request for a team August 23, 2023 04:37
@brofik brofik merged commit ee1670d into feat/TAPC-83 Aug 23, 2023
10 of 11 checks passed
@brofik brofik deleted the feat/TAPC-150 branch August 23, 2023 04:41
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y4nnL y4nnL Awaiting requested review from y4nnL y4nnL was automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene was automatically assigned from ovh/team-manager-dev-angularjs

@BrunoMarquesOVH BrunoMarquesOVH Awaiting requested review from BrunoMarquesOVH BrunoMarquesOVH was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brofik