-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRE-2386: use NEWest ARC #56
Conversation
Reviewer's Guide by SourceryThis PR migrates GitHub Actions workflows from using ubuntu-latest runners to self-hosted runners (utility-staging-amd64) as part of an initiative to move all CI to self-hosted infrastructure. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lilfrou - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding documentation about the capabilities and requirements of the utility-staging-amd64 runner, either in the workflow files or in a separate infrastructure documentation.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
i wonder why the runner did not pick up the Jobs only for this repository 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repository is a public repository. Please ignore public repositories.
oh , thank you for the clarification |
Linear Ticket
SRE-2386
Overview
Areas to focus on
Summary by Sourcery
CI: