Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRE-2386: use NEWest ARC #56

Closed
wants to merge 1 commit into from
Closed

SRE-2386: use NEWest ARC #56

wants to merge 1 commit into from

Conversation

lilfrou
Copy link

@lilfrou lilfrou commented Dec 12, 2024

Linear Ticket

SRE-2386

Overview

  • we are migrating all of our CI to selfhosted runner

Areas to focus on

  • use utility-staging-amd64

Summary by Sourcery

CI:

  • Migrate CI workflows to use the 'utility-staging-amd64' self-hosted runner instead of 'ubuntu-latest'.

Copy link

linear bot commented Dec 12, 2024

@lilfrou lilfrou self-assigned this Dec 12, 2024
Copy link

sourcery-ai bot commented Dec 12, 2024

Reviewer's Guide by Sourcery

This PR migrates GitHub Actions workflows from using ubuntu-latest runners to self-hosted runners (utility-staging-amd64) as part of an initiative to move all CI to self-hosted infrastructure.

File-Level Changes

Change Details Files
Migrated GitHub Actions workflows to use self-hosted runners
  • Replaced 'ubuntu-latest' with 'utility-staging-amd64' runner in all workflow files
  • Updated Docker publishing workflow runner configuration
  • Updated E2E testing workflow runner configuration
  • Updated unit testing workflow runner configuration
.github/workflows/docker-publish.yml
.github/workflows/e2e.yml
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lilfrou - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding documentation about the capabilities and requirements of the utility-staging-amd64 runner, either in the workflow files or in a separate infrastructure documentation.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lilfrou lilfrou closed this Dec 12, 2024
@lilfrou lilfrou reopened this Dec 12, 2024
@lilfrou
Copy link
Author

lilfrou commented Dec 12, 2024

i wonder why the runner did not pick up the Jobs only for this repository 👀

Copy link
Contributor

@h3poteto h3poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repository is a public repository. Please ignore public repositories.

@lilfrou
Copy link
Author

lilfrou commented Dec 16, 2024

This repository is a public repository. Please ignore public repositories.

oh , thank you for the clarification

@lilfrou lilfrou closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants