Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRE-2386: use newest ARC #57

Closed
wants to merge 1 commit into from
Closed

SRE-2386: use newest ARC #57

wants to merge 1 commit into from

Conversation

lilfrou
Copy link

@lilfrou lilfrou commented Dec 12, 2024

Summary by Sourcery

CI:

  • Update the CI workflow to run unit tests on the 'utility-staging-amd64' environment instead of 'ubuntu-latest'.

Copy link

linear bot commented Dec 12, 2024

Copy link

sourcery-ai bot commented Dec 12, 2024

Reviewer's Guide by Sourcery

The PR updates the GitHub Actions workflow to use a custom runner (utility-staging-amd64) instead of the default ubuntu-latest runner for unit tests.

File-Level Changes

Change Details Files
Updated GitHub Actions runner configuration for unit tests
  • Replaced default ubuntu-latest runner with utility-staging-amd64 custom runner
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lilfrou - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide more context about this change: Why are we switching to a custom runner? What testing has been done to verify all required dependencies are available on utility-staging-amd64?
  • The 'staging' designation in the runner name suggests this might be a pre-production environment. Please confirm if this runner is ready for production use.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lilfrou lilfrou closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant