-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kind: Allow to install custom kubevirt versions #4708
Conversation
ac7b885
to
0af16ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove inlining and expand them.
998f4cb
to
12a6a61
Compare
addressed comments, also created a function for it |
LGTM |
Thanks Quique, I think an approval via the review console is required please ? so it will be visible on the top right reviewers status list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
12a6a61
to
7a8f40a
Compare
rebased (had conflict) |
7a8f40a
to
b657219
Compare
added on PR desc info about (and also about the passt binary but this is not just due to this PR) |
b657219
to
db3fe7d
Compare
db3fe7d
to
644868c
Compare
rebased @qinqon can you please take another look ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @jcaamano could you take a quick look at this ? We are hoping to get this merged to improve the dev experience. |
closing and reopening so it will run again actions |
@oshoval could you push again? I generated a merge commit unintentionally. |
Signed-off-by: Or Shoval <[email protected]>
52a2b65
to
30bf85c
Compare
done, also cleaned white space |
What this PR does and why is it needed
Allow to install custom Kubevirt releases.
Also allows to freeze specific version upon needs, for example if newest breaks stuff,
or if a feature is required before a stable release exists.
Default stays deploy last stable as it was.
Since nightly doesn't release virtctl binary, keep using the latest stable released virtctl.
Use by exporting optional env var
KUBEVIRT_VERSION
with the requested value.Possible values of
KUBEVIRT_VERSION
:Which issue(s) this PR fixes
Fixes #
Special notes for reviewers
quay.io/kubevirt/network-passt-binding
does have nightly,in order to determine the tag, some more logic need to be added,
so for now only support stable
Note that the daemonset that deploys the passt binary use only stable releases,
but this is not due to this PR.
How to verify it
Details to documentation updates
Description for the changelog
Does this PR introduce a user-facing change?