Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kind: Allow to install custom kubevirt versions #4708

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

oshoval
Copy link
Contributor

@oshoval oshoval commented Sep 10, 2024

What this PR does and why is it needed

Allow to install custom Kubevirt releases.
Also allows to freeze specific version upon needs, for example if newest breaks stuff,
or if a feature is required before a stable release exists.

Default stays deploy last stable as it was.
Since nightly doesn't release virtctl binary, keep using the latest stable released virtctl.

Use by exporting optional env var KUBEVIRT_VERSION with the requested value.

Possible values of KUBEVIRT_VERSION:

stable - install newest stable (default)
vX.Y.Z - install specific stable (i.e v1.3.1)
nightly - install newest nightly
nightly tag - install specific nightly (i.e 20240910)

Which issue(s) this PR fixes

Fixes #

Special notes for reviewers

quay.io/kubevirt/network-passt-binding does have nightly,
in order to determine the tag, some more logic need to be added,
so for now only support stable

Note that the daemonset that deploys the passt binary use only stable releases,
but this is not due to this PR.

How to verify it

Details to documentation updates

Description for the changelog

Does this PR introduce a user-facing change?


@oshoval oshoval force-pushed the custom_kubevirt branch 2 times, most recently from ac7b885 to 0af16ca Compare September 10, 2024 11:11
@oshoval
Copy link
Contributor Author

oshoval commented Sep 10, 2024

/cc @maiqueb @qinqon
please take a look once you can, thanks
it will allow us to use kubevirt versions before a new stable is released (that might take time)

EDIT - failures are not related to the PR

@oshoval oshoval marked this pull request as ready for review September 10, 2024 13:01
@oshoval oshoval requested a review from a team as a code owner September 10, 2024 13:01
Copy link
Contributor

@qinqon qinqon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove inlining and expand them.

contrib/kind-common Outdated Show resolved Hide resolved
@oshoval oshoval force-pushed the custom_kubevirt branch 2 times, most recently from 998f4cb to 12a6a61 Compare September 12, 2024 10:45
@oshoval
Copy link
Contributor Author

oshoval commented Sep 12, 2024

addressed comments, also created a function for it

@qinqon
Copy link
Contributor

qinqon commented Sep 12, 2024

LGTM

@oshoval
Copy link
Contributor Author

oshoval commented Sep 12, 2024

LGTM

Thanks Quique, I think an approval via the review console is required please ? so it will be visible on the top right reviewers status list

Copy link
Contributor

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@oshoval
Copy link
Contributor Author

oshoval commented Sep 19, 2024

rebased (had conflict)
EDIT need to fix something

@oshoval
Copy link
Contributor Author

oshoval commented Sep 19, 2024

added on PR desc info about quay.io/kubevirt/network-passt-binding that was added lately
(also lets see tests passing)

(and also about the passt binary but this is not just due to this PR)

@oshoval
Copy link
Contributor Author

oshoval commented Sep 19, 2024

all failures are known flakes
#4709
#4733

@oshoval
Copy link
Contributor Author

oshoval commented Sep 23, 2024

rebased

@qinqon can you please take another look ?

Copy link
Contributor

@qinqon qinqon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maiqueb
Copy link
Contributor

maiqueb commented Oct 1, 2024

/cc @jcaamano

could you take a quick look at this ? We are hoping to get this merged to improve the dev experience.
Thanks in advance.

jcaamano
jcaamano previously approved these changes Oct 14, 2024
@oshoval
Copy link
Contributor Author

oshoval commented Oct 14, 2024

closing and reopening so it will run again actions
thx

@oshoval oshoval closed this Oct 14, 2024
@oshoval oshoval reopened this Oct 14, 2024
@jcaamano
Copy link
Contributor

@oshoval could you push again? I generated a merge commit unintentionally.

@oshoval
Copy link
Contributor Author

oshoval commented Oct 15, 2024

done, also cleaned white space
thx

@jcaamano jcaamano merged commit 93dbdf4 into ovn-org:master Oct 15, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants