Add hybird overlay pod IPs to the namespace address_set #4751
+167
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/unit-testing
pliurh
force-pushed
the
hybrid_overlay
branch
from
63f5bfb
to
80fe5be
Compare
npinaeva
reviewed
Oct 15, 2024
| hostNetworkIPs, err := oc.getHostNamespaceAddressesForNode(node) | ||
| if err != nil { | ||
| klog.Errorf("Error parsing annotation for node %s: %v", node.Name, err) | ||
| // during SDN live migration, add the SDN node GW IP to the host network address set. |
There was a problem hiding this comment.
this change is very openshift-specific, not sure if it belongs upstream...
There was a problem hiding this comment.
Can we have d/s only patch in openshift repo? If yes, I can propose this PR to d/s. But this code might be also valid for windows nodes if they also use the first IP of the host subnet for cross node host-to-pod traffic.
During live SDN migration, host-to-pod traffic originating from SDN nodes will use the first IP address of the hybrid overlay node subnet. These IPs are being added to ensure proper functionality of host network policies. Signed-off-by: Peng Liu <[email protected]>
Signed-off-by: Peng Liu <[email protected]>
pliurh
force-pushed
the
hybrid_overlay
branch
from
f4f2c11
to
47f3bec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does and why is it needed
The IPs of the pods that are on hybrid overlay nodes shall also be added to the namespace address_set. Also add SDN node subnet gateway IP to host-network namespace address_set.
Which issue(s) this PR fixes
Fixes https://issues.redhat.com//browse/OCPBUGS-42244, https://issues.redhat.com/browse/OCPBUGS-42605
Special notes for reviewers
How to verify it
Details to documentation updates
Description for the changelog
Does this PR introduce a user-facing change?