Bump to k8s 1.31.1 #4759
Open
Bump to k8s 1.31.1 #4759
+60,888
−60,227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind/documentation
github-actions
bot
added
feature/admin-network-policy
feature/egress-service
jcaamano
force-pushed
the
bump-1.31
branch
3 times, most recently
from
87df54b
to
085bc2e
Compare
|
not sure if you would like to include this, but we were going to add some CEL for the UDN CRD, there are TODOs like this https://github.com/ovn-org/ovn-kubernetes/blob/master/go-controller/pkg/crd/userdefinednetwork/v1/types.go#L213 |
jcaamano
force-pushed
the
bump-1.31
branch
2 times, most recently
from
9b0e1e3
to
e5d9182
Compare
tssurya
reviewed
Oct 9, 2024
Are there no tests for those CELs? |
jcaamano
force-pushed
the
bump-1.31
branch
2 times, most recently
from
bd69ea6
to
a2d5bd8
Compare
test/e2e/.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| vendor | |||
There was a problem hiding this comment.
nit: add end of line
jcaamano
force-pushed
the
bump-1.31
branch
2 times, most recently
from
01e2cf0
to
0c4b1a2
Compare
flavio-fernandes
added a commit
to flavio-fernandes/ovn-kubernetes
that referenced
this pull request
Oct 10, 2024
jcaamano
force-pushed
the
bump-1.31
branch
2 times, most recently
from
1a78431
to
28554da
Compare
not really :( |
15 tasks
jcaamano
force-pushed
the
bump-1.31
branch
3 times, most recently
from
4842690
to
4878de8
Compare
|
Failed job: e2e (control-plane, noHA, local, ipv6, noSnatGW, 1br, ic-single-node-zones) https://github.com/ovn-org/ovn-kubernetes/actions/runs/11325594330/job/31494087027?pr=4759 |
The problem is a crash in kube controller manager which delays quite a bit the creation of the default service account for namespaces The problem is a race condition where the cloud provider controller may initialize the event recorder too late introduced with We will most likely see this more. Thinking what to do but we will probably have to stay with 1.30.2 at runtime for a bit. |
TY for the info @jcaamano ! Assuming we are not planning on merging this any time soon, we may rebase network qos pr to master branch instead. It would be nice to address the codegen changes, tho. Do you think that could be done in an iterim pr |
Trying to understand the problem a bit more. It doesn't look like that is the first crash. There had to be another one before that is different because the manager should not be starting at the same time the tests are running. Also, one other option would be to disable the |
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
For go-controller: go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get sigs.k8s.io/[email protected] go mod vendor && go mod tidy Fixed API changes Fixed linting Updated codegen For e2e tests: go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get github.com/ovn-org/ovn-kubernetes/go-controller go mod edit -replace github.com/coreos/go-iptables=github.com/trozet/[email protected] go mod tidy (konnectivity-client is not at 0.31 yet) Fixed API changes Fixed skip for some upstream e2e tests that were added and we don't support Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
|
known flake: #4480 |
It seems that v1.31.1 introduced a bug in kube manager's service-lb-controller. Since we don't use a cloud provider, the controller is not fully initialized and started. However, its handlers are added to the informer and they do run. And when they do, it crashes because it is not fully initialized. Probably introduced through: kubernetes/kubernetes@50c1243 Disable service-lb-controller since it is not used anyway. bootstrap-signer-controller and token-cleaner-controller need to be added since they are not default and would otherwise be added by kind but not if we are overriding. Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For go-controller:
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get sigs.k8s.io/[email protected]
go mod vendor && go mod tidy
Fixed API changes
Fixed linting
Updated codegen
For e2e tests:
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get github.com/ovn-org/ovn-kubernetes/go-controller
go mod edit -replace github.com/coreos/go-iptables=github.com/trozet/[email protected]
go mod tidy
(konnectivity-client is not at 0.31 yet)
Fixed API changes