node annotations: add k8s.ovn.org/node-mgmt-port-info and provide mgmt ip address #4760
+202
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/unit-testing
flavio-fernandes
force-pushed
the
mgmt-port-info
branch
3 times, most recently
from
48a5d60
to
bd0d5ee
Compare
Instead of making an assumption about the IP address on
ovn-k8s-mp0, where it is expected to be the second IP of
node-subnet for the default/primary network, it is better
to provide this information through an annotation.
k8s.ovn.org/node-mgmt-port-info: {
"default": {
"ip-addresses": [ "10.192.13.2/26" ],
}
}
Signed-off-by: Flavio Fernandes <[email protected]>
flavio-fernandes
force-pushed
the
mgmt-port-info
branch
from
bd0d5ee
to
ce1a828
Compare
flavio-fernandes
changed the title
| // "l2-network": { | ||
| // "ip-addresses": [ "10.200.10.2/26" ], | ||
| // "mac-address": "5e:52:2a:c0:98:f4" | ||
| // } |
There was a problem hiding this comment.
Note: for this PR, only the ip-addresses attribute is being implemented. We chose to defer handling the other two as they are currently redundant. Also, mac addresses (plural) is new so it is a bit of a churn to change that yet again.
|
Known Flake: #4432 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of making an assumption about the IP address on ovn-k8s-mp0, where it is expected to be the second IP of node-subnet for the default/primary network, it is better to provide this information through an annotation.
In the future, we may entertain moving mac addresses and other properties to this, but that is no longer
part of this PR (Ref: https://github.com/flavio-fernandes/ovn-kubernetes/tree/mgmt-port-info.mac_and_vf).