Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] UDN: L2: Add missing remote LRPs: One step closer towards making external->services work on L2! #4777

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tssurya
Copy link
Member

@tssurya tssurya commented Oct 15, 2024

What this PR does and why is it needed

In the UDN enhancement https://github.com/openshift/enhancements/blob/master/enhancements/network/user-defined-network-segmentation.md#pod-egress we had discussed about adding remote ports on L2 switch for remote node's GR ports so that communication between GR's can work properly.

We somehow missed adding this with the L2 main topology

Which issue(s) this PR fixes

This fixes that since its required for external->services work on L2.

Special notes for reviewers

How to verify it

e2e tests are present in services section that supports this

Details to documentation updates

Description for the changelog

Adds remote LSP port for remote node's GR LRP on L2 UDPNs

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Surya Seetharaman <[email protected]>
@tssurya tssurya requested a review from a team as a code owner October 15, 2024 07:03
@tssurya tssurya changed the title UDN: L2: Add missing remote LRPs: One step closer towards making external->services work on L2! [WIP] UDN: L2: Add missing remote LRPs: One step closer towards making external->services work on L2! Oct 15, 2024
@tssurya
Copy link
Member Author

tssurya commented Oct 15, 2024

hmm locally it passes at v4 level and only fails v6, its weird this lane is failing at v4 itself!

@tssurya tssurya added the feature/user-defined-network-segmentation All PRs related to User defined network segmentation label Oct 16, 2024
@tssurya tssurya added this to the v1.1.0 milestone Oct 16, 2024
@qinqon
Copy link
Contributor

qinqon commented Oct 16, 2024

hmm locally it passes at v4 level and only fails v6, its weird this lane is failing at v4 itself!

Without he tunnel key collision fix, the L2 test can be failing.

@tssurya
Copy link
Member Author

tssurya commented Oct 16, 2024

@tssurya
Copy link
Member Author

tssurya commented Oct 16, 2024

hmm locally it passes at v4 level and only fails v6, its weird this lane is failing at v4 itself!

Without he tunnel key collision fix, the L2 test can be failing.

but I use keys from backside hehe while pods use it from front side, so idallocator doesn't give out 30657 or whatever is the highest id to the pod but but

its a race!! :) I don't see this happening always sooo maybe you are right here :) I will go with fixing this properly as discussed first and see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants