Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

add percentile tracking option #252

Merged
merged 1 commit into from
Oct 24, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/main/scala/org/http4s/metrics/micrometer/Meters4s.scala
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ object Meters4s {
private val TagReg = """([^:]*)\s*:\s*(.*)""".r

def apply[F[_]: Async](
reporter: Reporter[F]
reporter: Reporter[F],
percentiles: Set[Double] = Set.empty
): MetricsOps[F] =
new MetricsOps[F] {

Expand Down Expand Up @@ -75,7 +76,8 @@ object Meters4s {
reporter
.timer(
name(classifier, "response-headers-time"),
tags(classifier) ++ methodTags(method)
tags(classifier) ++ methodTags(method),
percentiles
)
.flatMap(_.record(elapsed.nanos))

Expand Down Expand Up @@ -127,7 +129,7 @@ object Meters4s {
elapsed: Long
): F[Unit] =
reporter
.timer(name(classifier, "response-time"), tags)
.timer(name(classifier, "response-time"), tags, percentiles)
.flatMap(_.record(elapsed.nanos))

private def methodTags(method: Method): Map[String, String] = Map(
Expand Down