Use InvalidArgumentException, because it's better then RuntimeExpcetion

ovr · Sep 16, 2015 · 553b094 · 553b094
1 parent 8114222
commit 553b094
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Visitor/Expression/AbstractExpressionCompiler.php b/src/Visitor/Expression/AbstractExpressionCompiler.php
@@ -5,10 +5,10 @@
 
 namespace PHPSA\Visitor\Expression;
 
+use Doctrine\Instantiator\Exception\InvalidArgumentException;
 use PHPSA\CompiledExpression;
 use PHPSA\Context;
 use PHPSA\Visitor\ExpressionCompilerInterface;
-use RuntimeException;
 
 abstract class AbstractExpressionCompiler implements ExpressionCompilerInterface
 {
@@ -21,7 +21,7 @@ abstract class AbstractExpressionCompiler implements ExpressionCompilerInterface
     protected function assertExpression($expression)
     {
         if (!$expression instanceof $this->name) {
-            throw new RuntimeException('Passed $expression must be instance of ' . $this->name);
+            throw new InvalidArgumentException('Passed $expression must be instance of ' . $this->name);
         }
     }
 

diff --git a/tests/PHPSA/Expression/ExpressionCompilerTest.php b/tests/PHPSA/Expression/ExpressionCompilerTest.php
@@ -19,7 +19,7 @@ public function testPassUnexpectedExpression()
         $this->assertSame('PhpParser\Node\Expr\UnaryMinus', $expr->getName());
 
         $this->setExpectedException(
-            'RuntimeException',
+            'InvalidArgumentException',
             'Passed $expression must be instance of PhpParser\Node\Expr\UnaryMinus'
         );
         $expr->pass($this->newFakeScalarExpr(), $this->getContext());