Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📊 UN urbanization data #2195

Merged
merged 17 commits into from
Jan 26, 2024
Merged

📊 UN urbanization data #2195

merged 17 commits into from
Jan 26, 2024

Conversation

veronikasamborska1994
Copy link
Contributor

@veronikasamborska1994 veronikasamborska1994 commented Jan 17, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced urban agglomeration datasets with updated averages, projections, and harmonized country data.
    • Introduced new garden datasets for urban agglomerations, including size classes and urban-rural distinctions.
    • Added grapher datasets to visualize urban agglomeration data and largest cities information.
  • Data Updates

    • Updated the World Urbanization Prospects Dataset with new figures for urban agglomerations of 300,000 inhabitants and above.
    • Included comprehensive data on the largest cities and capitals as of 2018.
    • Added size class information for urban settlements and detailed urban-rural population distributions.
  • Documentation

    • Provided metadata and licensing information for all new and updated datasets.

Copy link

coderabbitai bot commented Jan 23, 2024

Warning

Rate Limit Exceeded

@veronikasamborska1994 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 59 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between fd15e07 and a63139d.

Walkthrough

A series of updates have been made to the ETL (Extract, Transform, Load) process, involving the World Urbanization Prospects Dataset. These changes include loading and processing data related to urban agglomerations, urbanization trends, and classifications of urban settlements. The data is harmonized, averages and projections are calculated, and the datasets are saved in new formats for further analysis and visualization.

Changes

Files Changes
etl/steps/data/garden/un/2024-01-17/...
urban_agglomerations_definition.py,
urban_agglomerations_largest_cities.py,
urban_agglomerations_size_class.py,
urbanization_urban_rural.py
Scripts for loading, processing, and creating garden datasets.
etl/steps/data/grapher/un/2024-01-17/...
urban_agglomerations_300k.py,
urban_agglomerations_definition.py,
urban_agglomerations_largest_cities.py,
urban_agglomerations_size_class.py,
urbanization_urban_rural.py
Scripts for loading garden datasets and creating grapher datasets with the same metadata.
etl/steps/data/meadow/un/2024-01-17/...
urban_agglomerations_300k.py,
urban_agglomerations_definition.py,
urban_agglomerations_largest_cities.py,
urban_agglomerations_size_class.py,
urbanization_urban_rural.py
Scripts for loading snapshots, processing data, and creating meadow datasets.
snapshots/un/2024-01-17/...
urban_agglomerations_300k.py,
urban_agglomerations_largest_cities.csv.dvc,
urban_agglomerations_size_class.xls.dvc,
urbanization_urban_rural.csv.dvc,
urban_agglomerations_definition.xls.dvc
Snapshot files containing metadata and links to the World Urbanization Prospects Dataset.

🐇✨
In the garden of data, we've sown,
New seeds of knowledge have been grown.
With a hop, skip, and a code-laden leap,
We harvest insights, rich and deep.
🌱📊

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8ea578f and e1d41c7.
Files ignored due to path filters (14)
  • dag/main.yml is excluded by: !**/*.yml
  • dag/urbanization.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities_history.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities_history.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.excluded_countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.excluded_countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.meta.yml is excluded by: !**/*.yml
Files selected for processing (25)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities_history.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_largest_cities_history.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_largest_cities_history.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_300k.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities_history.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities_history.xls.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.xls.dvc (1 hunks)
  • snapshots/un/2024-01-17/urbanization_urban_rural.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
Files skipped from review due to trivial changes (4)
  • snapshots/un/2024-01-17/urban_agglomerations_300k.csv.dvc
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.csv.dvc
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.xls.dvc
  • snapshots/un/2024-01-17/urbanization_urban_rural.csv.dvc
Additional comments: 21
snapshots/un/2024-01-17/urban_agglomerations_size_class.py (1)
  • 13-20: The script is simple and follows Python best practices for creating a command-line interface with Click. The Snapshot creation and upload process is encapsulated in a single function call, which is good for maintainability.
snapshots/un/2024-01-17/urban_agglomerations_largest_cities_history.py (1)
  • 13-20: This script is identical to the previous one, urban_agglomerations_size_class.py, and follows the same best practices. It's clear and concise.
etl/steps/data/grapher/un/2024-01-17/urbanization_urban_rural.py (1)
  • 9-27: The script is concise and follows the pattern of loading a dataset, reading a table, and saving the output. It uses the create_dataset helper function, which is a good practice for code reuse and maintainability.
etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_300k.py (1)
  • 9-27: This script is identical to the previous one, urbanization_urban_rural.py, and follows the same best practices. It's clear and concise.
etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_size_class.py (1)
  • 9-27: This script is identical to the previous ones, urbanization_urban_rural.py and urban_agglomerations_300k.py, and follows the same best practices. It's clear and concise.
etl/steps/data/meadow/un/2024-01-17/urbanization_urban_rural.py (1)
  • 9-33: The script is well-structured and follows Python best practices for transforming data. It uses the create_dataset helper function, which is a good practice for code reuse and maintainability.
etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_largest_cities.py (1)
  • 9-34: This script is identical to the previous one, urbanization_urban_rural.py, and follows the same best practices. It's clear and concise.
etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_300k.py (1)
  • 9-35: This script is identical to the previous ones, urbanization_urban_rural.py and urban_agglomerations_largest_cities.py, and follows the same best practices. It's clear and concise.
etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_largest_cities_history.py (1)
  • 9-37: The script is well-structured and follows Python best practices for transforming data. It uses the create_dataset helper function, which is a good practice for code reuse and maintainability.
etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_largest_cities.py (1)
  • 9-38: This script is identical to the previous one, urban_agglomerations_largest_cities_history.py, and follows the same best practices. It's clear and concise.
etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities_history.py (1)
  • 10-40: The script is well-structured and follows Python best practices for transforming data. It uses the create_dataset helper function, which is a good practice for code reuse and maintainability.
etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.py (1)
  • 10-41: This script is identical to the previous one, urban_agglomerations_largest_cities_history.py, and follows the same best practices. It's clear and concise.
snapshots/un/2024-01-17/urban_agglomerations_largest_cities_history.xls.dvc (1)
  • 1-33: The DVC file contains appropriate metadata and origin information for the dataset. It follows the standard structure for DVC files and includes the necessary fields for dataset versioning and tracking.
etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.py (1)
  • 10-46: The script is well-structured and follows Python best practices for transforming data. It uses the create_dataset helper function, which is a good practice for code reuse and maintainability.
etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_largest_cities_history.py (1)
  • 9-60: This script is identical to the previous ones, urban_agglomerations_size_class.py and urban_agglomerations_largest_cities.py, and follows the same best practices. It's clear and concise.
etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_size_class.py (1)
  • 9-55: This script is identical to the previous ones, urban_agglomerations_largest_cities_history.py and urban_agglomerations_largest_cities.py, and follows the same best practices. It's clear and concise.
etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.py (1)
  • 15-73: The script is well-structured and follows Python best practices for transforming data. It uses the create_dataset helper function, which is a good practice for code reuse and maintainability.
etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.py (1)
  • 12-82: This script is identical to the previous one, urbanization_urban_rural.py, and follows the same best practices. It's clear and concise.
snapshots/un/2024-01-17/urban_agglomerations_largest_cities.py (1)
  • 15-117: The script is well-structured and follows Python best practices for downloading and processing data. It uses the Snapshot class for managing dataset snapshots and the df_to_file function for saving dataframes to files.
snapshots/un/2024-01-17/urban_agglomerations_300k.py (1)
  • 14-106: This script is identical to the previous one, urban_agglomerations_largest_cities.py, and follows the same best practices. It's clear and concise.
snapshots/un/2024-01-17/urbanization_urban_rural.py (1)
  • 14-114: The script is well-structured and follows Python best practices for downloading and processing data. It uses the Snapshot class for managing dataset snapshots and the df_to_file function for saving dataframes to files.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between b761582 and b3508fa.
Files ignored due to path filters (14)
  • dag/main.yml is excluded by: !**/*.yml
  • dag/urbanization.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities_history.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities_history.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.excluded_countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.excluded_countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.meta.yml is excluded by: !**/*.yml
Files selected for processing (25)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities_history.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_largest_cities_history.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_largest_cities_history.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_300k.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities_history.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities_history.xls.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.xls.dvc (1 hunks)
  • snapshots/un/2024-01-17/urbanization_urban_rural.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
Files skipped from review as they are similar to previous changes (25)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.py
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.py
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities_history.py
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.py
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_300k.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_largest_cities.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_largest_cities_history.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_size_class.py
  • etl/steps/data/grapher/un/2024-01-17/urbanization_urban_rural.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_300k.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_largest_cities.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_largest_cities_history.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_size_class.py
  • etl/steps/data/meadow/un/2024-01-17/urbanization_urban_rural.py
  • snapshots/un/2024-01-17/urban_agglomerations_300k.csv.dvc
  • snapshots/un/2024-01-17/urban_agglomerations_300k.py
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.csv.dvc
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.py
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities_history.py
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities_history.xls.dvc
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.py
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.xls.dvc
  • snapshots/un/2024-01-17/urbanization_urban_rural.csv.dvc
  • snapshots/un/2024-01-17/urbanization_urban_rural.py

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between b761582 and fd3fea6.
Files ignored due to path filters (12)
  • dag/main.yml is excluded by: !**/*.yml
  • dag/urbanization.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.excluded_countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.excluded_countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.meta.yml is excluded by: !**/*.yml
Files selected for processing (20)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_300k.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.xls.dvc (1 hunks)
  • snapshots/un/2024-01-17/urbanization_urban_rural.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
Files skipped from review as they are similar to previous changes (20)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.py
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.py
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.py
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_300k.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_largest_cities.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_size_class.py
  • etl/steps/data/grapher/un/2024-01-17/urbanization_urban_rural.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_300k.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_largest_cities.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_size_class.py
  • etl/steps/data/meadow/un/2024-01-17/urbanization_urban_rural.py
  • snapshots/un/2024-01-17/urban_agglomerations_300k.csv.dvc
  • snapshots/un/2024-01-17/urban_agglomerations_300k.py
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.csv.dvc
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.py
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.py
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.xls.dvc
  • snapshots/un/2024-01-17/urbanization_urban_rural.csv.dvc
  • snapshots/un/2024-01-17/urbanization_urban_rural.py

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 0e4fe57 and 186b9ae.
Files ignored due to path filters (12)
  • dag/main.yml is excluded by: !**/*.yml
  • dag/urbanization.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.excluded_countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.excluded_countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.meta.yml is excluded by: !**/*.yml
Files selected for processing (20)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_300k.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.xls.dvc (1 hunks)
  • snapshots/un/2024-01-17/urbanization_urban_rural.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
Files skipped from review as they are similar to previous changes (20)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.py
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.py
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.py
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_300k.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_largest_cities.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_size_class.py
  • etl/steps/data/grapher/un/2024-01-17/urbanization_urban_rural.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_300k.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_largest_cities.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_size_class.py
  • etl/steps/data/meadow/un/2024-01-17/urbanization_urban_rural.py
  • snapshots/un/2024-01-17/urban_agglomerations_300k.csv.dvc
  • snapshots/un/2024-01-17/urban_agglomerations_300k.py
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.csv.dvc
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.py
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.py
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.xls.dvc
  • snapshots/un/2024-01-17/urbanization_urban_rural.csv.dvc
  • snapshots/un/2024-01-17/urbanization_urban_rural.py

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 186b9ae and 7767ff1.
Files ignored due to path filters (3)
  • dag/urbanization.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_definition.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_shared.countries.json is excluded by: !**/*.json
Files selected for processing (8)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_definition.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_definition.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_definition.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_definition.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_definition.xls.dvc (1 hunks)
Files skipped from review due to trivial changes (1)
  • snapshots/un/2024-01-17/urban_agglomerations_definition.xls.dvc
Files skipped from review as they are similar to previous changes (3)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.py
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.py
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.py
Additional comments: 11
snapshots/un/2024-01-17/urban_agglomerations_definition.py (2)
  • 10-10: The approach to derive SNAPSHOT_VERSION from the file path ensures maintainability and reduces the risk of hardcoding version numbers.
  • 17-20: The snapshot creation and upload process is clear and concise. Ensure that the Snapshot class has proper error handling for the create_snapshot method, especially for the upload process.
etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_definition.py (2)
  • 14-17: Loading the garden dataset and reading the table is done in a straightforward manner. Ensure that the dataset loading and reading functions handle errors gracefully and log appropriately.
  • 22-27: Creating a new grapher dataset with the same metadata as the garden dataset is a good practice for consistency. Verify that the create_dataset function includes checks for metadata consistency and that it handles any discrepancies appropriately.
etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_definition.py (3)
  • 22-30: The logic to find the header row and re-read the file with the correct header is sound. However, ensure that there is error handling in case the header row is not found or if the re-reading process fails.
  • 32-38: Excluding specific columns and renaming for consistency is good for data clarity. Verify that the columns being excluded and the new column names are in line with the rest of the data processing pipeline.
  • 40-40: Using underscore to standardize column names and set_index to ensure data integrity is a best practice. Ensure that the underscore method is well-defined and that the set_index method has proper error handling for duplicate index cases.
etl/steps/data/garden/un/2024-01-17/urban_agglomerations_definition.py (4)
  • 29-30: Harmonizing country names using a shared JSON file is a good practice for consistency. Verify that the harmonize_countries function handles any mismatches or errors appropriately.
  • 33-37: The process of copying the definition column before applying a function to it is a good practice to preserve metadata. Ensure that the extract_min_inhabitants_accurate function is thoroughly tested for various formats of the definition string.
  • 39-39: Setting the index with country and year is appropriate for data organization. Verify that the data does not contain any duplicates that could cause issues with verify_integrity=True.
  • 53-57: The use of a regular expression to extract the minimum number of inhabitants is a robust method for parsing varied text formats. Ensure that the regular expression is tested against a wide range of expected inputs to prevent any data loss or corruption.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7767ff1 and 60e7e94.
Files ignored due to path filters (4)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.meta.yml is excluded by: !**/*.yml
Files selected for processing (1)
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.py

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 2a69ef0 and 8f1542a.
Files ignored due to path filters (13)
  • dag/main.yml is excluded by: !**/*.yml
  • dag/urbanization.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_definition.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_shared.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.excluded_countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.excluded_countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.meta.yml is excluded by: !**/*.yml
Files selected for processing (25)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_definition.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_definition.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_definition.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_300k.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_definition.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_definition.xls.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.xls.dvc (1 hunks)
  • snapshots/un/2024-01-17/urbanization_urban_rural.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
Files skipped from review as they are similar to previous changes (25)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.py
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_definition.py
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.py
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.py
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_300k.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_definition.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_largest_cities.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_size_class.py
  • etl/steps/data/grapher/un/2024-01-17/urbanization_urban_rural.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_300k.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_definition.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_largest_cities.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_size_class.py
  • etl/steps/data/meadow/un/2024-01-17/urbanization_urban_rural.py
  • snapshots/un/2024-01-17/urban_agglomerations_300k.csv.dvc
  • snapshots/un/2024-01-17/urban_agglomerations_300k.py
  • snapshots/un/2024-01-17/urban_agglomerations_definition.py
  • snapshots/un/2024-01-17/urban_agglomerations_definition.xls.dvc
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.csv.dvc
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.py
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.py
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.xls.dvc
  • snapshots/un/2024-01-17/urbanization_urban_rural.csv.dvc
  • snapshots/un/2024-01-17/urbanization_urban_rural.py

Copy link
Collaborator

@Marigold Marigold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! I'll test it again after you upload snapshots. If you have any ideas how to reduce boilerplate code, let us know ;).

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8f1542a and 636799b.
Files ignored due to path filters (3)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.meta.yml is excluded by: !**/*.yml
Files selected for processing (3)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_definition.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_300k.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_definition.xls.dvc (1 hunks)
Files skipped from review as they are similar to previous changes (3)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_definition.py
  • snapshots/un/2024-01-17/urban_agglomerations_300k.csv.dvc
  • snapshots/un/2024-01-17/urban_agglomerations_definition.xls.dvc

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7a5f04d and 99c0e07.
Files ignored due to path filters (13)
  • dag/main.yml is excluded by: !**/*.yml
  • dag/urbanization.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_definition.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_shared.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.excluded_countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.meta.yml is excluded by: !**/*.yml
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.excluded_countries.json is excluded by: !**/*.json
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.meta.yml is excluded by: !**/*.yml
Files selected for processing (25)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_definition.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_definition.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/grapher/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_definition.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • etl/steps/data/meadow/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_300k.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_300k.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_definition.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_definition.xls.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.py (1 hunks)
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.xls.dvc (1 hunks)
  • snapshots/un/2024-01-17/urbanization_urban_rural.csv.dvc (1 hunks)
  • snapshots/un/2024-01-17/urbanization_urban_rural.py (1 hunks)
Files skipped from review as they are similar to previous changes (25)
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_300k.py
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_definition.py
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_largest_cities.py
  • etl/steps/data/garden/un/2024-01-17/urban_agglomerations_size_class.py
  • etl/steps/data/garden/un/2024-01-17/urbanization_urban_rural.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_300k.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_definition.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_largest_cities.py
  • etl/steps/data/grapher/un/2024-01-17/urban_agglomerations_size_class.py
  • etl/steps/data/grapher/un/2024-01-17/urbanization_urban_rural.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_300k.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_definition.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_largest_cities.py
  • etl/steps/data/meadow/un/2024-01-17/urban_agglomerations_size_class.py
  • etl/steps/data/meadow/un/2024-01-17/urbanization_urban_rural.py
  • snapshots/un/2024-01-17/urban_agglomerations_300k.csv.dvc
  • snapshots/un/2024-01-17/urban_agglomerations_300k.py
  • snapshots/un/2024-01-17/urban_agglomerations_definition.py
  • snapshots/un/2024-01-17/urban_agglomerations_definition.xls.dvc
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.csv.dvc
  • snapshots/un/2024-01-17/urban_agglomerations_largest_cities.py
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.py
  • snapshots/un/2024-01-17/urban_agglomerations_size_class.xls.dvc
  • snapshots/un/2024-01-17/urbanization_urban_rural.csv.dvc
  • snapshots/un/2024-01-17/urbanization_urban_rural.py

@veronikasamborska1994 veronikasamborska1994 merged commit 522fa6d into master Jan 26, 2024
10 checks passed
@veronikasamborska1994 veronikasamborska1994 deleted the urbanization_un branch January 26, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants