Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 wizard: add metadata-export, love to chart revision #2287

Merged
merged 122 commits into from
Feb 16, 2024

Conversation

lucasrodes
Copy link
Member

@lucasrodes lucasrodes commented Feb 13, 2024

TL;DR

No need to review the code in detail, just try out the tool:

etl-wizard charts

and in see how it feels. Most changes should not be noticeable.

You can play with the GPT tool to tweak the FASTT. You can find it in the last step, where you have a preview of the charts (after submitting the variables).

Summary of what has been done

  • Add Metadata Export to Wizard.
    • Added under new tab "Actions" in Dataset Explorer
    • Added in the guidelines after submitting Garden create step.
  • Give some love to our Chart Revision Baker tool
    • Simplify and document some parts of the python back-end code
    • Better management of the streamlit st.session_state variable
    • Add GPT-based FASTT tweaking options to the chart preview section.
  • Add "Next step" button in the guidelines after submitting ETL create step.
  • Add harmonize in data explorer.

@lucasrodes lucasrodes changed the title wizard: add metadata-export, chartgpt 🎉 wizard: add metadata-export, chartgpt Feb 13, 2024
@lucasrodes lucasrodes added the wizard Issues related to wizard tool label Feb 13, 2024
Base automatically changed from feat/metadata-question to master February 13, 2024 15:54
@lucasrodes lucasrodes changed the title 🎉 wizard: add metadata-export, chartgpt 🎉 wizard: add metadata-export, love to chart revision Feb 13, 2024
@lucasrodes lucasrodes marked this pull request as ready for review February 14, 2024 02:50
@lucasrodes
Copy link
Member Author

@pabloarosado no need to review the code in detail. Can just run the chart revision tool and see how it feels

etl-wizard charts

Optionally, you can set DEBUG=True in the apps/wizard/charts/search_config.py file, to pre-select a dataset mapping.

@pabloarosado
Copy link
Contributor

Hey Lucas, everything looks great!
A minor thing I noticed, when submitting chart revisions, I get the following message: "Entered last step, but submission is None?".
Screenshot 2024-02-16 at 11 03 30
I don't know what it means, the submission seems to have worked well (they are in my local queue). And on that topic, I think it would be good to clarify that clicking on the "Finish" button means submitting chart revisions. Maybe instead of "Finish" you could call it "Submit chart revisions", or otherwise add a text above the button saying that.

Apart from that, I haven't looked into the code, but I understand you haven't changed anything affecting the data/metadata (except for the GPT suggestions, which seem to work as expected), so you can just merge so people can start using the tool. Good work!

Copy link
Contributor

@pabloarosado pabloarosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wizard works well.

@lucasrodes lucasrodes merged commit c5018c9 into master Feb 16, 2024
10 checks passed
@lucasrodes lucasrodes deleted the enhance/wizard-in-general branch February 16, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wizard Issues related to wizard tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants