Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 housekeeper: messages not showing chart preview #4075

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

lucasrodes
Copy link
Member

@lucasrodes lucasrodes commented Mar 5, 2025

The return object from a function was wrong. Fixing it should resume chart-previews from being shared in the daily housekeeper slack message.

/schedule

@owidbot
Copy link
Contributor

owidbot commented Mar 5, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-bug-housekeeper-issue

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2025-03-05 10:34:03 UTC
Execution time: 18.27 seconds

@lucasrodes lucasrodes changed the title 🐛 housekeeper not working 🐛 housekeeper: messages not showing chart preview Mar 5, 2025
Copy link

github-actions bot commented Mar 5, 2025

Merge Schedule
Scheduled to be merged the next time the merge action is scheduled via the cron expressions

Copy link

github-actions bot commented Mar 5, 2025

Merge Schedule
Scheduled merge failed: Pull Request is still a draft
In order to let the automerge-automation try again, the label "merge-schedule-failed" should be removed.

@github-actions github-actions bot added the merge-schedule-failed PR was attempted to be merged, but failed. label Mar 5, 2025
@lucasrodes lucasrodes marked this pull request as ready for review March 5, 2025 17:18
@lucasrodes lucasrodes merged commit 36d5f79 into master Mar 5, 2025
12 checks passed
@lucasrodes lucasrodes deleted the bug-housekeeper-issue branch March 5, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-schedule-failed PR was attempted to be merged, but failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants