Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Change 'main()' to 'run()' in snapshot templates #4081

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

pabloarosado
Copy link
Contributor

@pabloarosado pabloarosado commented Mar 7, 2025

Edit the wizard template for snapshot scripts, to write run() instead of main(). This would let us develop snapshot steps more easily with the new run-until-cursor extension (see #4058 ).

@owidbot
Copy link
Contributor

owidbot commented Mar 7, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-enhance-change-main-to

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2025-03-07 09:13:51 UTC
Execution time: 16.90 seconds

@pabloarosado pabloarosado marked this pull request as ready for review March 7, 2025 09:25
Copy link
Member

@lucasrodes lucasrodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@Marigold Marigold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pabloarosado pabloarosado merged commit 52a3333 into master Mar 7, 2025
16 checks passed
@pabloarosado pabloarosado deleted the enhance-change-main-to branch March 7, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants