🎉 Footer rework #4512
🎉 Footer rework #4512
Conversation
| @@ -33,14 +33,9 @@ | |||
| opacity: initial; | |||
| } | |||
| } | |||
| .oxford-logo img { | |||
There was a problem hiding this comment.
The viewboxes in the SVGs are set such that the borders in each graphic will all be flush when the SVG elements are the same height.
| @@ -1,131 +1,183 @@ | |||
| .site-footer { | |||
There was a problem hiding this comment.
I rewrote this from scratch so if you want to check this out I would just look at the new file without the diff.
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-02-05 18:02:46 UTC |
There was a problem hiding this comment.
Nice work! The code is more readable, and we got rid of unnecessary styles!
Not really a blocker, and I know this is more of a question for Marwa, but maybe you have talked about it already. We have three kinds of links in the footer:
- Bright white, no hover effect (in the leftmost paragraph)
- Bright white, gray on hover
- Grey, bright white on hover
This makes it a bit confusing to see what is a link and what is not. Could we make it a bit more consistent? Maybe remove the special case with 1. and make it behave as 2.? And/or add underline on hover to all bright white links instead of making them gray?
Even better, I'd like to see only a single style for links in the footer, but I'm afraid that's not Marwa's vision.
|
Oops, 1. was a mistake. Fixed now. Will send the staging link to Marwa for design sign off and then merge 👍 |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
Resolves #4430
Changes
.owid-layoutCSS utils that were only being used in the old footersite.footer.rework.mp4