✨ all-charts block updates #4514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesau
force-pushed
the
all-charts-updates
branch
from
17e1039 to
36da2f2
Compare
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-01-31 23:00:50 UTC |
rakyi
reviewed
Feb 4, 2025
baker/siteRenderers.tsx
Outdated
| @@ -414,6 +414,7 @@ ${dataInsights | |||
| homepageMetadata: get(post, "homepageMetadata", {}), | |||
| latestWorkLinks: get(post, "latestWorkLinks", []), | |||
| linkedChartViews: get(post, "linkedChartViews", {}), | |||
| tags: get(post, "tags", []) ?? [], | |||
There was a problem hiding this comment.
We already pass the default value ([]) to get, so we don't need the ?? [].
site/gdocs/OwidGdoc.tsx
Outdated
| @@ -94,6 +94,7 @@ export function OwidGdoc({ | |||
| homepageMetadata: get(props, "homepageMetadata", {}), | |||
| latestWorkLinks: get(props, "latestWorkLinks", []), | |||
| linkedChartViews: get(props, "linkedChartViews", {}), | |||
| tags: get(props, "tags", []) ?? [], | |||
There was a problem hiding this comment.
We already pass the default value ([]) to get, so we don't need the ?? [].
site/gdocs/components/AllCharts.scss
Outdated
Comment on lines
6
to
7
| // Any value smaller than -16 causes the h1 to wrap in Firefox | ||
| margin-left: -16px; |
There was a problem hiding this comment.
I played with this in Firefox and the negative margin seems unnecessary. Are you sure we need it?
site/gdocs/components/AllCharts.tsx
Outdated
| <a | ||
| className="deep-link" | ||
| aria-labelledby={ALL_CHARTS_ID} | ||
| href={`#${ALL_CHARTS_ID}`} | ||
| /> | ||
| </h1> | ||
| <a |
There was a problem hiding this comment.
Could we use the existing Button component here?
rakyi
approved these changes
Feb 5, 2025
| @@ -414,7 +414,8 @@ ${dataInsights | |||
| homepageMetadata: get(post, "homepageMetadata", {}), | |||
| latestWorkLinks: get(post, "latestWorkLinks", []), | |||
| linkedChartViews: get(post, "linkedChartViews", {}), | |||
| tags: get(post, "tags", []) ?? [], | |||
| // lodash doesn't use fallback when value is null | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4426
Changes
tagsto the gdoc AttachmentsContextall.charts.demo.mp4