chore(docker): update & simplify docker mysql setup #4565
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we're using an outdated Docker image (
mysql-server
) that hasn't been updated for two years.mysql
is now the official and recommended image, and unlike a few years ago it now also has a release for ARM Macs.So, we're now using
mysql:8
, which currently points to 8.4.It may make sense to update to
mysql:9
at some point, however we can only upgrade the DB in-place from a LTS release, which we are not currently on. Also, this would entail updating our prod servers, so...While playing around with this stuff, I also noticed that the custom
mysql-init-docker
container we are creating is entirely unnecessary: all the cli tools we need to run the update script (mostly justgunzip
and a few other basics) are already part of themysql:8
installation. Which means, we can now just use themysql:8
image instead :)For review purposes: You can go by commits here, they are self-contained.
Things I tested: