refactor: renovate FuzzySearch #4621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 3, 2025
|
Report too large to display inline |
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-03-03 13:11:14 UTC |
marcelgerber
force-pushed
the
fuzzy-search-improvements
branch
from
60895b1 to
1cbab99
Compare
marcelgerber
changed the title
marcelgerber
force-pushed
the
fuzzy-search-improvements
branch
2 times, most recently
from
6c20440 to
d7824e9
Compare
marcelgerber
force-pushed
the
fuzzy-search-improvements
branch
from
d7824e9 to
39724ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
FuzzySearchimplementation, which we're mostly using inside the entity selector, has fallen a bit by the wayside, and could need some love (especially since I'm tackling #4622).So, this PR
fuzzysort. changelog here, tl;dr: the order of results has slightly changed for the better, and it now supports stripping diacritics and accents, which is helpful forEspaña, for example.GDP -> gdp-world-bankandGDP -> gdp-maddison), useful for feat(entitySelector): allow searching for entities in multiple languages #4622.