-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vitest 🚀 #4628
Vitest 🚀 #4628
Changes from 26 commits
19d9e94
9b40e71
63359cd
21b4d1e
b1c354b
6f0fb6a
ca1f6e2
a8e2e2e
83c2806
f5faa20
763bec6
06d0b14
f910ca1
b4f35bb
c6830a5
fa57638
d6e83df
fa90962
5038333
63ee34a
f9174c9
f0531e6
912cee5
f06411c
d1c30e9
1fa5fdf
f5694dd
e016695
9eb52aa
f176378
2538474
5c845af
37253cd
072bd49
29b0bc1
ac0fa7a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Having a Vitest configuration shared across the team would be nice. Could we add one? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, sure, although I must say that I don't really use Launch configurations myself. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -224,19 +224,14 @@ tmp-downloads/owid_metadata.sql.gz: | |
test: node_modules | ||
@echo '==> Linting' | ||
yarn run eslint | ||
yarn lerna run build | ||
yarn lerna run buildTests | ||
|
||
@echo '==> Checking formatting' | ||
yarn testPrettierAll | ||
|
||
@echo '==> Running tests' | ||
yarn run jest | ||
yarn run test | ||
|
||
dbtest: node_modules | ||
@echo '==> Building' | ||
yarn buildTsc | ||
|
||
@echo '==> Running db test script' | ||
./db/tests/run-db-tests.sh | ||
|
||
|
@@ -254,7 +249,7 @@ format: node_modules | |
|
||
unittest: node_modules | ||
@echo '==> Running tests' | ||
yarn run jest --all | ||
yarn run test | ||
|
||
../owid-grapher-svgs: | ||
cd .. && git clone [email protected]:owid/owid-grapher-svgs | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added side effect: The
istJustJavascript
anddist/tests
dirs are pretty much things of the past.I haven't entirely gone rid of them at this point, but we're pretty close now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I last looked into this, i.e. when I introduced
tsx
, the main reason to keepistJustJavascript
was thattsx
runs esbuild every time, so we pay the cost of the transpilation on every restart of the process, e.g. the admin server, and also I wasn't sure how much ongoing overhead it incurs during runtime.I'm now more inclined to think it would be fine to use it in prod, but it warrants more investigation. See also their FAQ.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - this is certainly not something I want to change in this PR :)
Was just thinking that jest was one of the main consumers of
itsJustJavascript
, and that's now gone.