Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added codes for generating regulation-only closures #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yy20716
Copy link
Contributor

@yy20716 yy20716 commented Feb 22, 2018

I added additional codes for generating regulation-only/strict closures in owltools, as requested in this issue. I also slightly extended the testcase to confirm that closures are generated in the resulting SolrInputDocument objects, but please let me know if any other features or codes are necessary. Thank you.

@yy20716 yy20716 requested a review from kltm February 22, 2018 02:59
@kltm
Copy link
Member

kltm commented Feb 22, 2018

@cmungall I think this is correct, but as there is no controller flag to prevent annotation actions (or not), consumer will have to make sure that their installed config is compatible (ideally with AmiGO master caught up).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants