Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] OCIS: Auto Upload to other space that is not Personal #4214

Merged
merged 12 commits into from
Nov 28, 2023
Merged

[FEATURE REQUEST] OCIS: Auto Upload to other space that is not Personal #4214

merged 12 commits into from
Nov 28, 2023

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Nov 16, 2023 •
edited by jesmrec
Loading

Related Issues

App: #4117

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.2/Auto%20Uploads%20to%20Space.md

Reports:

@Aitorbp Aitorbp requested a review from JuancaG05 November 16, 2023 11:00
@Aitorbp Aitorbp self-assigned this Nov 16, 2023
@Aitorbp Aitorbp linked an issue Nov 16, 2023 that may be closed by this pull request
[FEATURE REQUEST] OCIS: Auto Upload to other space that is not Personal #4117
Closed
11 tasks
@JuancaG05 JuancaG05 changed the title FEATURE REQUEST] OCIS: Auto Upload to other space that is not Personal [FEATURE REQUEST] OCIS: Auto Upload to other space that is not Personal Nov 21, 2023
JuancaG05
JuancaG05 requested changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some work to do here yet @Aitorbp!

changelog/unreleased/4214 Outdated Show resolved Hide resolved
...ava/com/owncloud/android/presentation/settings/autouploads/SettingsPictureUploadsFragment.kt Outdated Show resolved Hide resolved
...va/com/owncloud/android/presentation/settings/autouploads/SettingsPictureUploadsViewModel.kt Outdated Show resolved Hide resolved
...va/com/owncloud/android/presentation/settings/autouploads/SettingsPictureUploadsViewModel.kt Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/activity/FolderPickerActivity.kt Outdated Show resolved Hide resolved
...va/com/owncloud/android/data/spaces/datasource/implementation/OCLocalSpacesDataSourceTest.kt Outdated Show resolved Hide resolved
...n/src/main/java/com/owncloud/android/domain/camerauploads/model/FolderBackUpConfiguration.kt Outdated Show resolved Hide resolved
owncloudDomain/src/main/java/com/owncloud/android/domain/spaces/usecases/GetSpaceByIdUseCase.kt Outdated Show resolved Hide resolved
owncloudDomain/src/main/java/com/owncloud/android/domain/spaces/usecases/GetSpaceByIdUseCase.kt Outdated Show resolved Hide resolved
owncloudDomain/src/main/java/com/owncloud/android/domain/spaces/model/OCSpace.kt Outdated Show resolved Hide resolved
@Aitorbp Aitorbp force-pushed the feature/auto_upload_to_other_space_not_personal branch 5 times, most recently from 2b0d511 to 83588c2 Compare November 21, 2023 17:10
@Aitorbp Aitorbp requested a review from JuancaG05 November 22, 2023 08:38
JuancaG05
JuancaG05 requested changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments here! @Aitorbp 👨🏼‍💻

...java/com/owncloud/android/presentation/settings/autouploads/SettingsVideoUploadsViewModel.kt Outdated Show resolved Hide resolved
owncloudData/src/main/java/com/owncloud/android/data/migrations/Migration_43.kt Outdated Show resolved Hide resolved
@Aitorbp Aitorbp requested a review from JuancaG05 November 23, 2023 12:37
JuancaG05
JuancaG05 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 24, 2023 •
edited
Loading

(1) [FIXED]

  1. Fresh install
  2. Add oC10 account
  3. Add oCIS account
  4. Enter in Settings and enable Auto Uploads (oCIS account setup by default because it was the last one to be added)
  5. Click on Account to upload path and select the oC10 account
  6. Click on Picture upload path and select a different path

Current: null: in subtitle of the Picture upload path
Expected: just the path

Pixel2 Android11
2f0f9b5cb9

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 27, 2023 •
edited
Loading

(2) [WONT FIX]

  1. Install v4.1.1 in device
  2. Add an oCIS account
  3. Enable auto uploads and select any folder as upload path
  4. Update to the current version (migration)

Current: upload path without Personal: subtitle
Expected: after migrating to the new version, oCIS accounts should mark the upload path with the space, not only the path. As the previous version only allows to set a path on the personal space, the upload path subtitle should be Personal: <path>

Pixel2 Android11
7341fb015

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 27, 2023

(2) is not an issue. Local branching mess on my side.

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 28, 2023

About the report (1), i still see the null in the oC10 accounts. If i switch from oCIS to oC10 and change the path, it appears again:

Screen_recording_20231128_083250.mp4

tested with 2f0f9b5cb

@Aitorbp
Copy link
Contributor Author

Aitorbp commented Nov 28, 2023

About the report (1), i still see the null in the oC10 accounts. If i switch from oCIS to oC10 and change the path, it appears again:

Screen_recording_20231128_083250.mp4
tested with 2f0f9b5cb

Try with this 5761b2dd59fcea48cc54bd05bc94129a61397780

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 28, 2023

Try with this 5761b2d

not reproducible anymore with that commit. Fixed then

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 28, 2023

Approved! ready to go!

@Aitorbp Aitorbp force-pushed the feature/auto_upload_to_other_space_not_personal branch from 5761b2d to 5cb5293 Compare November 28, 2023 12:21
@Aitorbp Aitorbp merged commit ec30ba3 into master Nov 28, 2023
2 checks passed
@Aitorbp Aitorbp deleted the feature/auto_upload_to_other_space_not_personal branch November 28, 2023 12:46
Aitorbp added a commit that referenced this pull request Feb 5, 2024
@Aitorbp
Merge pull request #4214 from owncloud/feature/auto_upload_to_other_s…
6357de8 
…pace_not_personal

[FEATURE REQUEST] OCIS: Auto Upload to other space that is not Personal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees

@Aitorbp Aitorbp

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] OCIS: Auto Upload to other space that is not Personal
3 participants
@Aitorbp @jesmrec @JuancaG05