Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix Detekt workflow because paths makes PR not to trigger it #4539

Merged
merged 1 commit into from
Jan 31, 2025
Merged

[FIX] Fix Detekt workflow because paths makes PR not to trigger it #4539

merged 1 commit into from
Jan 31, 2025

Conversation

jesmrec
Copy link
Collaborator

@jesmrec jesmrec commented Jan 31, 2025

Related Issues

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@jesmrec jesmrec force-pushed the test/check_trigger_detekt branch from 3297033 to bee468c Compare January 31, 2025 13:48
@jesmrec jesmrec requested a review from joragua January 31, 2025 13:48
joragua
joragua approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jesmrec jesmrec changed the title Test Fix Detekt workflow Jan 31, 2025
@jesmrec jesmrec changed the title Fix Detekt workflow Fix Detekt workflow because paths makes PR nost to trigger it Jan 31, 2025
@jesmrec jesmrec changed the title Fix Detekt workflow because paths makes PR nost to trigger it Fix Detekt workflow because paths makes PR not to trigger it Jan 31, 2025
@joragua joragua changed the title Fix Detekt workflow because paths makes PR not to trigger it [FIX] Fix Detekt workflow because paths makes PR not to trigger it Jan 31, 2025
@jesmrec jesmrec merged commit 9bd4268 into master Jan 31, 2025
7 checks passed
@jesmrec jesmrec deleted the test/check_trigger_detekt branch January 31, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joragua joragua joragua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesmrec @joragua