Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix store update strategy #349

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix store update strategy #349

merged 1 commit into from
Jul 5, 2023

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jul 4, 2023

Description

The store needs a static update strategy recreate because it is not scalable and thus will probably use RWO storage.
In this case the new pod will be probably pending forever because the RWO volume might be mounted on a differnt node.

Related Issue

Motivation and Context

have no pending pods when using RWO volumes

How Has This Been Tested?

  • none

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

Copy link
Contributor

@d7oc d7oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside the fact that this will also introduce a little downtime while this SPOF pod is being recreated.

@wkloucek
Copy link
Contributor Author

wkloucek commented Jul 5, 2023

LGTM aside the fact that this will also introduce a little downtime while this SPOF pod is being recreated.

Yes, this also applies to all other SPOFs: #15 (comment)

@wkloucek wkloucek merged commit 9314822 into master Jul 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-update-strategy-when-rwo branch July 5, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants