Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] adding test for disabling mail notifications #10820

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Jan 1, 2025

Description

This PR adds test for disabling mail notification

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1: ci
  • test case 2: locally
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Jan 1, 2025
@nirajacharya2 nirajacharya2 force-pushed the test-notification-disable-setting branch from ce732b2 to 1f778da Compare January 1, 2025 09:50
@nirajacharya2 nirajacharya2 marked this pull request as ready for review January 1, 2025 10:30
@nirajacharya2 nirajacharya2 force-pushed the test-notification-disable-setting branch from 1f778da to 112ab53 Compare January 2, 2025 09:07
@nirajacharya2 nirajacharya2 force-pushed the test-notification-disable-setting branch from 112ab53 to f2af8f4 Compare January 2, 2025 10:36
@nirajacharya2 nirajacharya2 force-pushed the test-notification-disable-setting branch from f2af8f4 to 35a12b2 Compare January 2, 2025 10:43
@nirajacharya2 nirajacharya2 changed the title [tests-only][full-ci] adding test for disabling mail and in-app notifications [tests-only][full-ci] adding test for disabling mail notifications Jan 2, 2025
@nirajacharya2 nirajacharya2 force-pushed the test-notification-disable-setting branch from 35a12b2 to 4d4717c Compare January 2, 2025 10:45
@nirajacharya2 nirajacharya2 force-pushed the test-notification-disable-setting branch 2 times, most recently from 785ca87 to 72be5b5 Compare January 2, 2025 11:15
@nirajacharya2 nirajacharya2 force-pushed the test-notification-disable-setting branch from 72be5b5 to 464d28f Compare January 3, 2025 10:47
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 if CI is happy

@nirajacharya2 nirajacharya2 force-pushed the test-notification-disable-setting branch from d32a39e to 92f0708 Compare January 10, 2025 07:08
@nirajacharya2 nirajacharya2 requested a review from saw-jan January 10, 2025 07:08
@nirajacharya2 nirajacharya2 force-pushed the test-notification-disable-setting branch 2 times, most recently from 2e8708a to 7d26b04 Compare January 10, 2025 08:26
@nirajacharya2 nirajacharya2 force-pushed the test-notification-disable-setting branch 2 times, most recently from 4171f79 to 3bab86d Compare January 10, 2025 08:29
@nirajacharya2 nirajacharya2 force-pushed the test-notification-disable-setting branch from 3bab86d to e1d8066 Compare January 13, 2025 03:17
@nirajacharya2 nirajacharya2 requested a review from saw-jan January 13, 2025 03:18
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@saw-jan saw-jan merged commit 2d30d12 into master Jan 13, 2025
4 checks passed
@saw-jan saw-jan deleted the test-notification-disable-setting branch January 13, 2025 08:19
ownclouders pushed a commit that referenced this pull request Jan 13, 2025
…ting

[tests-only][full-ci] adding test for disabling mail notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants