Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] refactor scenarios to remove multiple listAllNotifications request in steps #10969

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

prashant-gurung899
Copy link
Contributor

@prashant-gurung899 prashant-gurung899 commented Feb 5, 2025

Description

This PR refactors the notifications test scenarios such that there are no multiple steps that requests to list all the in-app notifications
Originated from: #10928 (comment)

In some notification test scenarios, we were using steps like follow:

When user "Brian" lists all notifications
Then the HTTP status code should be "200"
And user "Brian" should get a notification with subject "Space shared" and message:

In this case, listing all notifications request(listAllNotifications) was called twice.

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 force-pushed the test/refactor-list-notification-steps branch from f63b241 to 9543b02 Compare February 5, 2025 11:40
@prashant-gurung899 prashant-gurung899 changed the title [tests-only][full-ci] refactor notification test scenarios [tests-only][full-ci] refactor scenarios to remove multiple listAllNotifications request in steps Feb 5, 2025
Copy link

sonarqubecloud bot commented Feb 5, 2025

Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prashant-gurung899 prashant-gurung899 merged commit 0a34853 into master Feb 6, 2025
4 checks passed
@prashant-gurung899 prashant-gurung899 deleted the test/refactor-list-notification-steps branch February 6, 2025 08:18
ownclouders pushed a commit that referenced this pull request Feb 6, 2025
…on-steps

[tests-only][full-ci] refactor scenarios to remove multiple `listAllNotifications` request in steps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants