Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Fix notification cleanup and retry #10972

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Feb 6, 2025

Description

This PR fix notification retry test code and cleanup mail and in-app after every notification-related scenario
A new tag @notification has been introduced, which does in-app and mail notification cleanup in the after hook.
@email will be used for specifying email-related tests scenario

  • Removed @skipOnStable3.0 tag because there is no used of it.

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Contributor

@nirajacharya2 nirajacharya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like expected-failures files need to be updated

tests/acceptance/bootstrap/NotificationContext.php Outdated Show resolved Hide resolved
@amrita-shrestha amrita-shrestha force-pushed the fix-notification-tests-code branch from 71207e8 to b4017cc Compare February 10, 2025 06:57
@amrita-shrestha amrita-shrestha merged commit 654308e into master Feb 10, 2025
4 checks passed
@amrita-shrestha amrita-shrestha deleted the fix-notification-tests-code branch February 10, 2025 09:01
ownclouders pushed a commit that referenced this pull request Feb 10, 2025
[tests-only][full-ci] Fix notification cleanup and retry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants