-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] add e2e test for progress bars #132
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: nabim777 <[email protected]>
6375fd9
to
012bb0e
Compare
5a70aa9
to
2b7121c
Compare
Signed-off-by: nabim777 <[email protected]>
2b7121c
to
59e6483
Compare
await logout(adminPage) | ||
}) | ||
|
||
test('select the progressBarOption from the web-app-progress-bars extension', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test('select the progressBarOption from the web-app-progress-bars extension', async () => { | |
test('select the progressBarOption on the account page', async () => { |
this only tests if the dropdown shows the Nyan Cat option and if its selectable, nothing more
Signed-off-by: nabim777 <[email protected]>
1c12e36
to
9bfe0fb
Compare
await logout(adminPage) | ||
}) | ||
|
||
test('select the progressBarOption on the account page', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test('select the progressBarOption on the account page', async () => { | |
test('select NyanCat progressBarOption on the account page', async () => { |
await this.accountManageBtn.click() | ||
} | ||
|
||
async selectProgressBarExtension(){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
async selectProgressBarExtension(){ | |
async selectNyanCatProgressBarExtension(){ |
|
||
this.progressBarSelector = this.page.locator('.extension-preference .vs__search') | ||
this.progressBarCurrent = this.page.locator('.extension-preference .vs__selected span') | ||
this.progressBarOption = this.page.getByText('Nyan Cat progress bar') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.progressBarOption = this.page.getByText('Nyan Cat progress bar') | |
this.nyanCatProgressBarOption = this.page.getByText('Nyan Cat progress bar') |
await this.progressBarSelector.waitFor() | ||
await this.progressBarSelector.click() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO click wait for selector to be visibile https://playwright.dev/docs/api/class-locator#locator-click why to add expicit waitfor ?
await this.progressBarSelector.waitFor() | |
await this.progressBarSelector.click() | |
await this.progressBarSelector.click() |
Description
In this PR, an e2e test is added for the
web-app-progress-bar
extension.And currently there is only one web-app-progress-bar named
Nyan Cat progress bar
, so there is only a test for it.steps added:
account manage
pageNyan Cat progress bar
Test run command
Related Issue
Screenshots (if appropriate):
Following video shows what's automated in the E2E test for
web-app-progress-bar
extension (added in this PR)Screencast.from.01-22-2025.04.50.54.PM.webm
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: