Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(password-protected-folders): open folder in an iframe #12142

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Jan 29, 2025

Description

Add modal rendering an iframe with the public link content using a limited UI.

Related Issue

Motivation and Context

Give users a way to open password protected folders

How Has This Been Tested?

  • test environment: chrome & 🤖
  • test case 1: open a folder in the browser
  • test case 2: extended unit tests

Screenshots (if appropriate):

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • merge previous PRs
  • add changelog
  • fill out PR description
  • rebase

@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Jan 29, 2025
@LukasHirt LukasHirt self-assigned this Jan 29, 2025
@LukasHirt LukasHirt force-pushed the feat/psec-popup branch 2 times, most recently from e7bfeeb to f0d9b1e Compare January 30, 2025 08:45
Add modal rendering an iframe with the public link content using a limited UI.
@LukasHirt LukasHirt marked this pull request as ready for review January 30, 2025 09:00
@LukasHirt LukasHirt requested a review from saw-jan January 30, 2025 09:00
@LukasHirt LukasHirt merged commit 4d6641d into master Jan 30, 2025
4 checks passed
@LukasHirt LukasHirt deleted the feat/psec-popup branch January 30, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants