Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(password-protected-folders): hide extension and actions #12145

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

LukasHirt
Copy link
Collaborator

Description

Hide .psec extensions, hide all actions except delete, and display default actions in context menu.

Related Issue

Motivation and Context

Make the file look more like a folder

How Has This Been Tested?

  • test environment: chrome & 🤖
  • test case 1: create a folder, open context menu and see available actions
  • test case 2: create a folder, open sidebar and see available actions

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Jan 30, 2025
@LukasHirt LukasHirt requested a review from saw-jan January 30, 2025 10:48
@LukasHirt LukasHirt self-assigned this Jan 30, 2025
@saw-jan
Copy link
Member

saw-jan commented Jan 30, 2025

I still see the file extension 🤔

Screenshot from 2025-01-30 17-54-28 Screenshot from 2025-01-30 17-54-35

@LukasHirt
Copy link
Collaborator Author

I forgot to push the latest changes... should be working now

Copy link

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2025-02-03 11-28-20

👍

@LukasHirt LukasHirt merged commit 6391d5d into master Feb 3, 2025
4 checks passed
@LukasHirt LukasHirt deleted the feat/psec-actions branch February 3, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants