fix(ast): estree compat AssignmentTargetPropertyIdentifier

[hi-ogawa]

This one seemed less straight forward than AssignmentTargetPropertyProperty, so I split it from #9005. This requires somewhat redundant custom serialization logic, but this is all I came up with. I'm curious to know if there's any good shortcut for this.

[hi-ogawa]

• fix(ast): estree compat AssignmentTargetPropertyIdentifier #9006 👈 (View in Graphite)
• fix(ast): estree compat AssignmentTargetPropertyProperty #9005
• fix(ast): estree compat ArrayAssignmentTarget #8998
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #9006 will not alter performance

_{Comparing fix-estree-AssignmentTargetPropertyIdentifier (22d93be) with main (dd927a6)}

Summary

✅ 33 untouched benchmarks

[overlookmotel]

Yes, I think there's a simpler way to implement this. Merging this now, and I'll do a follow-up PR.

[overlookmotel]

Merge activity

• Feb 10, 10:16 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Feb 10, 10:24 AM EST: A user added this pull request to the Graphite merge queue.
• Feb 10, 10:31 AM EST: A user merged this pull request with the Graphite merge queue.

[overlookmotel]

@hi-ogawa By the way, it's been a bit of a struggle to get all these PRs merged, due to inadequacies in Graphite and the merge conflicts in the snapshot file.

One thing that would help is if you'd be able to squash all PRs down to a single commit each please. Multiple commits should be no problem, but squashing seems to confuse Graphite less.

Also, please feel free to merge your own PRs in this area of work. If it passes more tests, it's good! I can always follow up after they're merged if I want to make tweaks or query anything.

[hi-ogawa]

@hi-ogawa By the way, it's been a bit of a struggle to get all these PRs merged, due to inadequacies in Graphite and the merge conflicts in the snapshot file.

One thing that would help is if you'd be able to squash all PRs down to a single commit each please. Multiple commits should be no problem, but squashing seems to confuse Graphite less.

Also, please feel free to merge your own PRs in this area of work. If it passes more tests, it's good! I can always follow up after they're merged if I want to make tweaks or query anything.

@overlookmotel Understood! Sorry about the conflict and thanks for taking care of them 🙏 I'll try to proceed my own for easier merge.