Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider multiple correct results in equations-parser automated tests #49

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Consider multiple correct results in equations-parser automated tests #49

merged 1 commit into from
Nov 30, 2023

Conversation

Victorcorcos
Copy link
Contributor

@Victorcorcos Victorcorcos commented Nov 28, 2023 •
edited
Loading

Description ✍️

Now, on the automated tests, it is possible to consider multiple correct answers instead of just one

For example, the following code:

test_eval '0 / 0' 'nan' '-nan'

Means that 0 / 0 can be either nan or -nan. Two valid options.

@Victorcorcos Victorcorcos self-assigned this Nov 28, 2023
EduardoRSeifert
EduardoRSeifert approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@EduardoRSeifert EduardoRSeifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will approve, but why is this needed? aren't test results supposed to be deterministic?

@Victorcorcos
Copy link
Contributor Author

@EduardoRSeifert 0 / 0 returns -nan on the drone and nan here locally. 0 / 0 can be either nan or -nan.

@Victorcorcos
Copy link
Contributor Author

@EduardoRSeifert can you approve again?

EduardoRSeifert
EduardoRSeifert approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@EduardoRSeifert EduardoRSeifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@Victorcorcos Victorcorcos merged commit fea0e4d into oxeanbits:master Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduardoRSeifert EduardoRSeifert EduardoRSeifert approved these changes

Assignees

@Victorcorcos Victorcorcos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Victorcorcos @EduardoRSeifert