Disable server-side tx "sanity checks" #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagerman
force-pushed
the
remove-sanity-check
branch
from
cd8fc18
to
66b676e
Compare
jagerman
force-pushed
the
remove-sanity-check
branch
from
66b676e
to
d3edf1e
Compare
The checks here break wallets sometimes (see issue oxen-io#1639). They aren't really "sanity checks" anyway because there are lots of legitimate ways a wallet could end up producing such a transaction, especially with Oxen's relatively low output creation rate.
jagerman
force-pushed
the
remove-sanity-check
branch
from
d3edf1e
to
47264e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checks here break wallets sometimes (see issue #1639). They aren't really "sanity checks" anyway because there are lots of legitimate ways a wallet could end up producing such a transaction, especially with Oxen's relatively low output creation rate.