wip: replace pem with pem-rfc7468 crate
#52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skimmed rfc 7468 for a few minutes and I can't find anything that would require padding out the base64 encoded data. §7 has an example pkcs#10 (CSR) object pem encoded and there isn't any padding like this. Next step is to dive into the pem-rfc7468 code to see where this is coming from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will resolve #50 but I've left it as a draft because the CSRs it produces are padded with a stream of 'A's like so:
I don't have time to figure out whether I've done something wrong, this is expected behavior (check rfc 7468), or it's something else / bug. It handles certs fine and is a drop-in replacement for the existing implementation (decodes certs created by opensl fine).