Skip to content

Commit

Permalink
wip: upgrade vsss_rs to 5.1.0
Browse files Browse the repository at this point in the history
This update becamse necessary because the old version of `vsss-rs` was
holding back the RustCrypto crates (p256, rsa etc) w/ shared / conflicting
dependencies. This is evident in the net loss in the Cargo.lock file
despite adding a new dependency.

We maintain backward compatibility w/ the hex format for shares when
they're output through the printer and input via stdio. Share I/O using
ISO & CDW now serialize shares as JSON. I'm not wild about serializing
types from a dependency as we don't control if / when these might
change but for now we're no worse off than we were.

This has been tested by creating, destroying, and then recovering OKS
instances w/ shares round tripped through:
- printer output, stdio input
- ISO output & input
- CDW output & CDR input
  • Loading branch information
flihp committed Feb 25, 2025
1 parent 6c3f643 commit 3bb1bae
Show file tree
Hide file tree
Showing 8 changed files with 576 additions and 522 deletions.
599 changes: 264 additions & 335 deletions Cargo.lock

Large diffs are not rendered by default.

9 changes: 3 additions & 6 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ log = "0.4.22"
lpc55_sign = { git = "https://github.com/oxidecomputer/lpc55_support", default-features = false, version = "0.3.4" }
lpc55_areas = { git = "https://github.com/oxidecomputer/lpc55_support", default-features = false, version = "0.2.4" }
num-bigint = "0.4.6"
# p256 v0.13 has a dependency that requires rustc 1.65 but we're pinned
# to 1.64 till offline-keystore-os supports it
p256 = "0.12"
p256 = "0.13"
pem-rfc7468 = { version = "0.7.0", features = ["alloc", "std"] }
rand = "0.8.5"
rand_core = { version = "0.6.4", features = ["std"] }
Expand All @@ -30,9 +28,7 @@ static_assertions = "1.1.0"
tempfile = "3.13.0"
textwrap = "0.16.1"
thiserror = "1.0.64"
# vsss-rs v3 has a dependency that requires rustc 1.65 but we're pinned
# to 1.64 till offline-keystore-os supports it
vsss-rs = "2.7.1"
vsss-rs = "5.1.0"
x509-cert = "0.2.5"
yubihsm = { git = "https://github.com/oxidecomputer/yubihsm.rs", branch = "session-close", features = ["usb", "untested"] }
zeroize = "1.8.1"
Expand All @@ -41,3 +37,4 @@ glob = "0.3.2"
rsa = "0.9.3"
sha2 = "0.10.8"
zerocopy = { version = "0.8.17", features = ["derive", "std", "zerocopy-derive"] }
const_format = "0.2.34"
Loading

0 comments on commit 3bb1bae

Please sign in to comment.