Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Crucible #839

Closed
wants to merge 2 commits into from
Closed

Bump Crucible #839

wants to merge 2 commits into from

Conversation

mkeeter
Copy link
Contributor

@mkeeter mkeeter commented Jan 24, 2025

No description provided.

@mkeeter mkeeter requested a review from leftwo January 24, 2025 21:16
Copy link
Collaborator

@pfmooney pfmooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this need an update to the lock file as well?

@mkeeter
Copy link
Contributor Author

mkeeter commented Jan 24, 2025

@pfmooney whoops yes

@leftwo
Copy link
Contributor

leftwo commented Jan 24, 2025

I may want to merge crucible ace54d9c up as well, could we hold this for that?

@mkeeter
Copy link
Contributor Author

mkeeter commented Jan 24, 2025

Sure, feel free to push directly to this branch since it's EOD here

@leftwo
Copy link
Contributor

leftwo commented Jan 25, 2025

I see your PR and raise you one: #840

@pfmooney
Copy link
Collaborator

Addressed by #840.

@pfmooney pfmooney closed this Jan 26, 2025
@mkeeter mkeeter deleted the bump-crucible branch January 27, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants