generically handle package version pinning #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, looks good! |
sunshowers
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Could you also update https://github.com/oxidecomputer/renovate-config/tree/main/rust#exclusions to just mention that writing = will cause crates to be skipped?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In oxidecomputer/omicron#5786 I changed the version field for vsss-rs to
=3.3.4to preventcargo update(and the "lock file maintenance" Renovate task) from bumping the version. Similarly in oxidecomputer/omicron#5926 I'm also marking sled's version dependency in the same way.Instead of listing individual packages to ignore in the Renovate config, it seems nicer to overload the
=sigil with the additional meaning of "hey Renovate, please ignore this crate entirely".(Note that I am not certain how to test if this works properly.)