feat: add whiskers palette file and documentation #3
Conversation
|
If you accept this, I'm not sure how you'd want it linked into the main |
ozwaldorf
force-pushed
the
main
branch
9 times, most recently
from
5be8870
to
f11a2c9
Compare
|
Whoops, what a coincidence, sorry for the force pushes! This is a great addition and opens the door to a lot of easy access to ports. Honestly, I wouldn't mind just having whiskers.json at the top level and documentation along with the other usage sections |
|
I wonder if this could also be integrated into the nix flake, through hm modules (ie, if zed reads themes from a dir, we can generate and write it there). Not a requirement just ideating |
|
I've never worked with Nix before, but tomorrow I can move this stuff into the top level and try to resolve the force push conflicts at least. |
|
By the way, this is what the resulting Zed color scheme looks like: |
I tested with the whiskers CLI tool a bit more and found which exact colors cause it to break. I changed the rest of the colors back to match the rest of the Carburetor theme.
dacid44
force-pushed
the
feature/whiskers-support
branch
from
866ae2d
to
ae63be2
Compare
dacid44
force-pushed
the
feature/whiskers-support
branch
from
ae63be2
to
a222447
Compare
carburetor-whiskers.json
Outdated
| @@ -0,0 +1,86 @@ | |||
| { | |||
There was a problem hiding this comment.
Sorry for the nit, but could probably have this in examples/whiskers.json
Otherwise lgtm!
There was a problem hiding this comment.
Possibly, I'd argue you might want to rename the examples directory in that case though. The stuff in there right now is less "examples" and more "here, it's done for you already". Not that it matters too much as long as the documentation links to it properly.
There was a problem hiding this comment.
I agree, it was previously src, I might move it back to that
|
Sure, if I don't lose track of it. Here's the issue from whiskers: catppuccin/whiskers#32 Though for now, it's probably fine. Only about 3 colors needed to be changed in the end, and not by enough that it would really be noticeable. Still, it does annoy me to have to change the colors just to work around a bug. |
resolves #2