Move txin base weight calculation #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base weight calculation was previously provided by rust-bitcoin but has since been removed. Furthermore, the removed base weight calculation had a logic error where it should have been multiplied by 4. This PR provides a local base weight calculation and uses from_vb which multiplies by 4 since the components of the base weight are not part of segwit.
yancyribbens
force-pushed
the
bug/base-weight-calculation-error
branch
from
5c5d69a
to
286ad04
Compare
|
closing in favor of #27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking this as draft for now until PR rust-bitcoin/rust-bitcoin#2206 is reviewed. If it's brought into master I'll move this PR out of draft state.
The base weight calculation was previously provided by rust-bitcoin but has since been removed. Furthermore, the removed base weight calculation had a logic error where it should have been multiplied by 4. This PR provides a local base weight calculation and uses from_vb which multiplies by 4 since the components of the base weight are not part of segwit.