Log channel balances before deleting channel data #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be even nicer to log the `ChannelDetails`, but then we would have to modify the macro and that is too painful.
Tibo-lg
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be even nicer to log the
ChannelDetails, but then we would have to modify the macro and that is too painful.@Tibo-lg: this can help us spend the funding TXO with the right values in case the
ChannelDetailshave been erased and the channel wasn't closed correctly. That would mean that there is a bug, since after you implemented handling theChannelClosedevent inrust-dlcwe expect any (most?) channel closure to work.