Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rust-lightning:0.0.117 #15

Open
wants to merge 16 commits into
base: split-tx-experiment-117
Choose a base branch
from

Commits on Dec 18, 2023

  1. Revert "Drop dep tokio's io-util feat as it broke MSRV and isn't …

    …useful"
    
    This reverts commit eb882a6.
    
    The reverted commit introduced a regression causing the subchannel
    open protocol to hang because a particularly large message was not
    being sent over in full (one of the chunks was seemingly stuck).
    luckysori committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    fabcb68 View commit details
    Browse the repository at this point in the history
  2. backport: Fix deadlock when closing an unavailable channel

    I've backported from the 0.0.118 release since it seems like we could
    easily run into this by attempting to close a channel that is already
    closed or that never existed in the first place.
    Fedeparma74 authored and luckysori committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    88cabaa View commit details
    Browse the repository at this point in the history
  3. backport: Drop unreachable shutdown code in Channel::get_shutdown

    `Channel` is only a thing for funded channels. Thus, checking if a
    channel has not yet been funded is dead code and can simply be
    elided.
    TheBlueMatt authored and luckysori committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    9861fcd View commit details
    Browse the repository at this point in the history
  4. backport: Move pre-funded-channel immediate shutdown logic to the rig…

    …ht place
    
    Because a `Funded` `Channel` cannot possibly be pre-funding, the
    logic in `ChannelManager::close_channel_internal` to handle
    pre-funding channels is in the wrong place.
    
    Rather than being handled inside the `Funded` branch, it should be
    in an `else` following it, handling either of the two
    `ChannelPhases` outside of `Funded`.
    
    Sadly, because of a previous control flow management `loop {}`, the
    existing code will infinite loop, which is fixed here.
    TheBlueMatt authored and luckysori committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    7798852 View commit details
    Browse the repository at this point in the history
  5. backport: Immediately error in close_channel_internal if there is n…

    …o chan
    
    Previously, unfunded channels would be stored outside of
    `PeerState::channel_by_id`, and thus if there is no channel when
    we look in `PeerState::channel_by_id`, `close_channel_internal`
    called `force_close_channel_with_peer` to hunt for unfunded
    channels.
    
    However, that is no longer the case, so the call is redundant, and
    we can simply return an error instead.
    TheBlueMatt authored and luckysori committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    0b465c0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f49cffe View commit details
    Browse the repository at this point in the history
  7. Fix pinned dependency in CI

    Tibo-lg authored and luckysori committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    3f32a40 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Run CI checks only on PR push

    If you want to check what CI says you can always just open a (draft)
    PR.
    luckysori committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    98af90f View commit details
    Browse the repository at this point in the history
  2. Run check-each-commit.sh based on PR base branch

    Most PRs target `main`, but for those PRs that target a different
    branch it is more efficient to target the PR base branch.
    
    Otherwise we can end up running the script for too many commits and
    run into a timeout on CI.
    luckysori committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    1ab006b View commit details
    Browse the repository at this point in the history
  3. Enable spliting lightning channel

    Tibo-lg authored and luckysori committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    d553106 View commit details
    Browse the repository at this point in the history
  4. Check and return commit tx number

    Tibo-lg authored and luckysori committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    2a4d495 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f4822e9 View commit details
    Browse the repository at this point in the history
  6. Revert TLV type change for original_funding_outpoint

    The (de)serialisation for `ChannelTransactionParameters` changed
    between 0.0.114 and 0.0.116. This type had already been modified by us
    when adding the `original_funding_outpoint` field. When first
    introduced, we chose a type value of 14.
    
    After the update, we chose to reduce it down to 12 since the type 12
    was no longer being used after changes between 0.0.114 and 0.0.116.
    Unfortunately, this unnecessarily broke channels created before the
    update.
    
    Eventually we will need to settle on a way to handle these possible
    conflicts with upstream. Tibo already suggested a few options:
    
    - Use much larger numbers for `rust-dlc` custom fields.
    - Move LDK values around as we rebase on top of new changes.
    - Add a subdomain for `rust-dlc` custom fields.
    luckysori committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    807402c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9283634 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    23f4cfe View commit details
    Browse the repository at this point in the history
  9. Log channel balances before deleting channel data

    It would be even nicer to log the `ChannelDetails`, but then we would
    have to modify the macro and that is too painful.
    luckysori committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    15c4ff6 View commit details
    Browse the repository at this point in the history