-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to rust-lightning:0.0.117
#15
base: split-tx-experiment-117
Are you sure you want to change the base?
Commits on Dec 18, 2023
-
Revert "Drop dep
tokio
'sio-util
feat as it broke MSRV and isn't ……useful" This reverts commit eb882a6. The reverted commit introduced a regression causing the subchannel open protocol to hang because a particularly large message was not being sent over in full (one of the chunks was seemingly stuck).
Configuration menu - View commit details
-
Copy full SHA for fabcb68 - Browse repository at this point
Copy the full SHA fabcb68View commit details -
backport: Fix deadlock when closing an unavailable channel
I've backported from the 0.0.118 release since it seems like we could easily run into this by attempting to close a channel that is already closed or that never existed in the first place.
Configuration menu - View commit details
-
Copy full SHA for 88cabaa - Browse repository at this point
Copy the full SHA 88cabaaView commit details -
backport: Drop unreachable shutdown code in
Channel::get_shutdown
`Channel` is only a thing for funded channels. Thus, checking if a channel has not yet been funded is dead code and can simply be elided.
Configuration menu - View commit details
-
Copy full SHA for 9861fcd - Browse repository at this point
Copy the full SHA 9861fcdView commit details -
backport: Move pre-funded-channel immediate shutdown logic to the rig…
…ht place Because a `Funded` `Channel` cannot possibly be pre-funding, the logic in `ChannelManager::close_channel_internal` to handle pre-funding channels is in the wrong place. Rather than being handled inside the `Funded` branch, it should be in an `else` following it, handling either of the two `ChannelPhases` outside of `Funded`. Sadly, because of a previous control flow management `loop {}`, the existing code will infinite loop, which is fixed here.
Configuration menu - View commit details
-
Copy full SHA for 7798852 - Browse repository at this point
Copy the full SHA 7798852View commit details -
backport: Immediately error in
close_channel_internal
if there is n……o chan Previously, unfunded channels would be stored outside of `PeerState::channel_by_id`, and thus if there is no channel when we look in `PeerState::channel_by_id`, `close_channel_internal` called `force_close_channel_with_peer` to hunt for unfunded channels. However, that is no longer the case, so the call is redundant, and we can simply return an error instead.
Configuration menu - View commit details
-
Copy full SHA for 0b465c0 - Browse repository at this point
Copy the full SHA 0b465c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f49cffe - Browse repository at this point
Copy the full SHA f49cffeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f32a40 - Browse repository at this point
Copy the full SHA 3f32a40View commit details
Commits on Dec 20, 2023
-
If you want to check what CI says you can always just open a (draft) PR.
Configuration menu - View commit details
-
Copy full SHA for 98af90f - Browse repository at this point
Copy the full SHA 98af90fView commit details -
Run check-each-commit.sh based on PR base branch
Most PRs target `main`, but for those PRs that target a different branch it is more efficient to target the PR base branch. Otherwise we can end up running the script for too many commits and run into a timeout on CI.
Configuration menu - View commit details
-
Copy full SHA for 1ab006b - Browse repository at this point
Copy the full SHA 1ab006bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d553106 - Browse repository at this point
Copy the full SHA d553106View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a4d495 - Browse repository at this point
Copy the full SHA 2a4d495View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4822e9 - Browse repository at this point
Copy the full SHA f4822e9View commit details -
Revert TLV type change for original_funding_outpoint
The (de)serialisation for `ChannelTransactionParameters` changed between 0.0.114 and 0.0.116. This type had already been modified by us when adding the `original_funding_outpoint` field. When first introduced, we chose a type value of 14. After the update, we chose to reduce it down to 12 since the type 12 was no longer being used after changes between 0.0.114 and 0.0.116. Unfortunately, this unnecessarily broke channels created before the update. Eventually we will need to settle on a way to handle these possible conflicts with upstream. Tibo already suggested a few options: - Use much larger numbers for `rust-dlc` custom fields. - Move LDK values around as we rebase on top of new changes. - Add a subdomain for `rust-dlc` custom fields.
Configuration menu - View commit details
-
Copy full SHA for 807402c - Browse repository at this point
Copy the full SHA 807402cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9283634 - Browse repository at this point
Copy the full SHA 9283634View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23f4cfe - Browse repository at this point
Copy the full SHA 23f4cfeView commit details -
Log channel balances before deleting channel data
It would be even nicer to log the `ChannelDetails`, but then we would have to modify the macro and that is too painful.
Configuration menu - View commit details
-
Copy full SHA for 15c4ff6 - Browse repository at this point
Copy the full SHA 15c4ff6View commit details