Update p4-examples README #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated p4-examples with the up-to-date instructions and made it a proper markdown file. Signed-off-by: Vladimir Gurevich <[email protected]>
jafingerhut
reviewed
Jan 22, 2025
pkgsrc/p4-examples/README.md
Outdated
| To build all P4_14 examples use the command: | ||
|
|
||
| ``` | ||
| $SDE/p4studio/p4studio build p4-16-programs |
There was a problem hiding this comment.
Shouldn't the command to build all P4_14 programs be different than the one to build all P4_16 programs above?
jafingerhut
reviewed
Jan 22, 2025
pkgsrc/p4-examples/README.md
Outdated
| sudo $SDE_INSTALL/bin/veth_setup.sh | ||
| ``` | ||
|
|
||
| To run the PTF tests on the Tofino Model you will need 3 separate windows (or, at least, shell sessions). Again, it |
There was a problem hiding this comment.
Incomplete sentence "Againt, it" above. Remove, or complete the thought?
jafingerhut
reviewed
Jan 22, 2025
pkgsrc/p4-examples/README.md
Outdated
| * `p4_16_programs` | ||
| Example P4_16 programs | ||
| * `programs` | ||
| Example P4_14 programs/to |
There was a problem hiding this comment.
The "/to" at the end of this line looks like a typo.
jafingerhut
reviewed
Jan 22, 2025
pkgsrc/p4-examples/README.md
Outdated
| $SDE/run_p4_tests.sh [--arch tofino2] -p example_name | ||
| ``` | ||
|
|
||
| Please, be aware that the scripts mentioned above have special code to make running the examples as easy as possible by being aware and properly consuming additional files stored in the examples' subdirectores. Running your pwn programs and their PTF tests might require additional options. |
Fixed the typos as per @jafingerhut 's comments Signed-off-by: Vladimir Gurevich <[email protected]>
|
Thanks, @jafingerhut -- all fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated p4-examples with the up-to-date instructions and made it a proper markdown file.